Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix release/v0.33.2 #4039

Merged
merged 5 commits into from Apr 3, 2019
Merged

Hotfix release/v0.33.2 #4039

merged 5 commits into from Apr 3, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 3, 2019

Update Tendermint to v0.31.0-dev0-fix0 as it fixes critical security vulnerabilities. This update technically includes a minor API breaking change in GenPrivKeySecp256k1.

/cc @ebuchman @zmanian


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez mentioned this pull request Apr 3, 2019
10 tasks
@alexanderbez alexanderbez marked this pull request as ready for review April 3, 2019 20:04
Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


#### Tendermint

* Upgrade Tendermint to `v0.31.0-dev0-fix0` which includes critical security fixes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention what fixes in the changelog?

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #4039 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4039      +/-   ##
==========================================
- Coverage   60.85%   60.84%   -0.02%     
==========================================
  Files         192      192              
  Lines       14289    14289              
==========================================
- Hits         8696     8694       -2     
- Misses       5026     5028       +2     
  Partials      567      567

@ebuchman ebuchman merged commit f6985c8 into master Apr 3, 2019
@alexanderbez alexanderbez deleted the release/v0.33.2 branch April 3, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants