Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param Change Proposal #4206

Merged
merged 108 commits into from
Apr 30, 2019
Merged

Param Change Proposal #4206

merged 108 commits into from
Apr 30, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 26, 2019

This PR addresses the implementation of parameter change proposals. It's major features and changes include:

  • Minor updates to the x/param module
    • Cleanup and moving types to types/ package
    • New ParameterChangeProposal and ParamChange types
  • Updates to the x/gov module
    • Cleanup and moving types to types/ package
    • Disable SoftwareUpgrade proposals
    • Implement Content and Handler interfaces
    • Implement and use internal Content router in the keeper
    • Update EndBlocker to execute Content handler
  • Update docs
  • Update client functionality

This is state machine breaking. The proposal's Content JSON field has been renamed and SoftwareUpgrade are temporarily disabled.

A follow up PR should be made to add param change proposals to simulation.


replaces/supersedes: #3880
closes: #3565

credit: @mossid


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! - Good design, and nice refactors.

general comments on the docs, and code structure - nothing too big.

docs/spec/governance/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/governance/02_state.md Outdated Show resolved Hide resolved
docs/spec/governance/02_state.md Outdated Show resolved Hide resolved
docs/spec/governance/02_state.md Show resolved Hide resolved
docs/spec/governance/02_state.md Outdated Show resolved Hide resolved
x/gov/types/msgs.go Show resolved Hide resolved
x/params/types/proposal.go Show resolved Hide resolved
x/params/types/proposal.go Outdated Show resolved Hide resolved
x/params/handler.go Outdated Show resolved Hide resolved
cmd/gaia/app/app.go Outdated Show resolved Hide resolved
mossid and others added 6 commits April 30, 2019 09:54
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #4206 into master will increase coverage by 0.27%.
The diff coverage is 48.33%.

@@            Coverage Diff             @@
##           master    #4206      +/-   ##
==========================================
+ Coverage   60.17%   60.45%   +0.27%     
==========================================
  Files         212      218       +6     
  Lines       15187    15355     +168     
==========================================
+ Hits         9139     9283     +144     
- Misses       5419     5432      +13     
- Partials      629      640      +11

alexanderbez and others added 2 commits April 30, 2019 10:43
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
x/gov/client/cli/tx.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor Author

@rigelrozanski @cwgoes @mossid I've addressed all your comments :)

Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gov T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter Change Proposal
8 participants