Update swagger file with tested GET routes #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
sabau
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
sabau
added
ready-for-review
T:Docs
Codecov Report
@@ Coverage Diff @@
## master #4470 +/- ##
======================================
Coverage 54.6% 54.6%
======================================
Files 250 250
Lines 16076 16076
======================================
Hits 8779 8779
Misses 6650 6650
Partials 647 647 |
fedekunze
approved these changes
Jun 3, 2019
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
alexanderbez
suggested changes
Jun 3, 2019
| @@ -234,11 +234,17 @@ paths: | |||
| - application/json | |||
| parameters: | |||
| - in: query | |||
| name: tag | |||
| name: action | |||
There was a problem hiding this comment.
Why is the name action here? It can be any key. Can we omit name?
There was a problem hiding this comment.
In this situation, it's to have a working example, I wanted to add a link to the tags page in the docs to specify you could add any tag defined there, but it won't work until we update from swagger 2.0 to OpenAPI 3.0
alexanderbez
reviewed
Jun 3, 2019
| @@ -0,0 +1 @@ | |||
| align swagger file to run contract tests | |||
There was a problem hiding this comment.
I don't understand this pending log entry...not very informative imho. Perhaps we either remove it or state what's actually of tangible use to the consumer?
alessio
pushed a commit
to cosmos/gaia
that referenced
this pull request
Jun 8, 2019
Closes: #17 Depends on: cosmos/cosmos-sdk#4470
bchainexpt
pushed a commit
to bchainexpt/Blockchain-wallet-andorid-app
that referenced
this pull request
Apr 4, 2022
Closes: #17 Depends on: cosmos/cosmos-sdk#4470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A route had to be commented as it's returning 500 instead of 200 with empty body -> will make the tests fail:
Related to:
Contract test [GET] gaia#19
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: