-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swagger file with tested GET routes #4470
Conversation
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4470 +/- ##
======================================
Coverage 54.6% 54.6%
======================================
Files 250 250
Lines 16076 16076
======================================
Hits 8779 8779
Misses 6650 6650
Partials 647 647 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending changelog entry and TODO comment on the slashing info
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- one minor nit :)
@@ -234,11 +234,17 @@ paths: | |||
- application/json | |||
parameters: | |||
- in: query | |||
name: tag | |||
name: action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the name action
here? It can be any key. Can we omit name
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this situation, it's to have a working example, I wanted to add a link to the tags page in the docs to specify you could add any tag defined there, but it won't work until we update from swagger 2.0
to OpenAPI 3.0
@@ -0,0 +1 @@ | |||
align swagger file to run contract tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this pending log entry...not very informative imho. Perhaps we either remove it or state what's actually of tangible use to the consumer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Closes: #17 Depends on: cosmos/cosmos-sdk#4470
Closes: #17 Depends on: cosmos/cosmos-sdk#4470
A route had to be commented as it's returning 500 instead of 200 with empty body -> will make the tests fail:
Related to:
Contract test [GET] gaia#19
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: