v0.36.0 Changelog Updates #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
fedekunze
approved these changes
Aug 13, 2019
tac0turtle
reviewed
Aug 13, 2019
| A bit more verbose, but also allows `context.WithTimeout()`, etc and only used | ||
| in one function in this repo, in test code. | ||
| * [\#3685](https://github.com/cosmos/cosmos-sdk/issues/3685) Add `SetAddressVerifier` and `GetAddressVerifier` to `sdk.Config` to allow SDK users to configure custom address format verification logic (to override the default limitation of 20-byte addresses). | ||
| * [\#3685](https://github.com/cosmos/cosmos-sdk/issues/3685) Add an additional parameter to NewAnteHandler for a custom `SignatureVerificationGasConsumer` (the default logic is now in `DefaultSigVerificationGasConsumer). This allows SDK users to configure their own logic for which key types are accepted and how those key types consume gas. |
There was a problem hiding this comment.
Suggested change
| * [\#3685](https://github.com/cosmos/cosmos-sdk/issues/3685) Add an additional parameter to NewAnteHandler for a custom `SignatureVerificationGasConsumer` (the default logic is now in `DefaultSigVerificationGasConsumer). This allows SDK users to configure their own logic for which key types are accepted and how those key types consume gas. | |
| * [\#3685](https://github.com/cosmos/cosmos-sdk/issues/3685) Add an additional parameter to NewAnteHandler for a custom `SignatureVerificationGasConsumer` (the default logic is now in `DefaultSigVerificationGasConsumer`). This allows SDK users to configure their own logic for which key types are accepted and how those key types consume gas. |
tac0turtle
reviewed
Aug 13, 2019
| - Renamed `x/distribution` `ModuleName` | ||
| - Genesis JSON and CLI now use `distribution` instead of `distr` | ||
| - Introduce `ModuleAccount` type, which tracks the flow of coins held within a module | ||
| - Replaced `FeeCollectorKeeper` for a `ModuleAccount` |
There was a problem hiding this comment.
I would link to the docs of the supply module, this is fairly vague for a breaking change, but this changelog is so big people may avoid it
Codecov Report
@@ Coverage Diff @@
## master #4900 +/- ##
=======================================
Coverage 54.03% 54.03%
=======================================
Files 269 269
Lines 17130 17130
=======================================
Hits 9256 9256
Misses 7186 7186
Partials 688 688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]Re-reviewed
Files changedin the github PR explorerFor Admin Use: