Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc/04-channel: import export GenesisState #6087

Merged
merged 15 commits into from
Apr 29, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Apr 27, 2020

Closes: #5948

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added x/ibc C:genesis relating to chain genesis labels Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #6087 into master will increase coverage by 0.20%.
The diff coverage is 91.15%.

@@            Coverage Diff             @@
##           master    #6087      +/-   ##
==========================================
+ Coverage   54.57%   54.78%   +0.20%     
==========================================
  Files         436      437       +1     
  Lines       26296    26436     +140     
==========================================
+ Hits        14352    14482     +130     
- Misses      10952    10958       +6     
- Partials      992      996       +4     

x/ibc/04-channel/types/genesis.go Outdated Show resolved Hide resolved
x/ibc/04-channel/types/genesis.go Outdated Show resolved Hide resolved
x/ibc/04-channel/types/genesis.go Outdated Show resolved Hide resolved
@fedekunze fedekunze marked this pull request as ready for review April 27, 2020 21:48
@fedekunze fedekunze added R4R and removed WIP labels Apr 27, 2020
…cosmos-sdk into fedekunze/import-export-ibc-pt-3

[ci skip]
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the Channel changes.

x/ibc/04-channel/types/channel.go Outdated Show resolved Hide resolved
x/ibc/04-channel/types/channel.go Outdated Show resolved Hide resolved
x/ibc/04-channel/types/genesis.go Outdated Show resolved Hide resolved
x/ibc/04-channel/keeper/keeper.go Outdated Show resolved Hide resolved
x/ibc/04-channel/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit 2d3a852 into master Apr 29, 2020
@fedekunze fedekunze deleted the fedekunze/import-export-ibc-pt-3 branch April 29, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:genesis relating to chain genesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add import/export for client, connection, channel states
3 participants