Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Capabilities with Uncached Context #6136

Merged
merged 1 commit into from
May 4, 2020

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented May 4, 2020

Description

Cleaner fix than one implemented in #6127

Uses a different helper function that explicitly creates uncached context


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #6136 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #6136      +/-   ##
==========================================
- Coverage   54.83%   54.83%   -0.01%     
==========================================
  Files         439      439              
  Lines       26492    26494       +2     
==========================================
  Hits        14527    14527              
- Misses      10968    10970       +2     
  Partials      997      997              

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 4, 2020
@mergify mergify bot merged commit 687d424 into master May 4, 2020
@mergify mergify bot deleted the aditya/uncache-context branch May 4, 2020 18:52
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alessio pushed a commit to cosmos/gaia that referenced this pull request May 11, 2020
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants