Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove viper global singleton from x/genutil #6596

Merged
merged 68 commits into from
Jul 6, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Jul 3, 2020

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #6596 into master will decrease coverage by 0.32%.
The diff coverage is 52.20%.

@@            Coverage Diff             @@
##           master    #6596      +/-   ##
==========================================
- Coverage   57.99%   57.66%   -0.33%     
==========================================
  Files         370      493     +123     
  Lines       23551    29621    +6070     
==========================================
+ Hits        13659    17082    +3423     
- Misses       8941    11314    +2373     
- Partials      951     1225     +274     

@alexanderbez alexanderbez mentioned this pull request Jul 3, 2020
27 tasks
@alexanderbez
Copy link
Contributor

@jgimeno please rebase this and target against #6599 :)

@alexanderbez alexanderbez mentioned this pull request Jul 3, 2020
9 tasks
@jgimeno jgimeno marked this pull request as ready for review July 6, 2020 19:39
@jgimeno jgimeno requested a review from alexanderbez July 6, 2020 19:43
@jgimeno jgimeno added the R4R label Jul 6, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jgimeno! I left a few comments and questions 👍

client/context.go Outdated Show resolved Hide resolved
x/auth/types/txbuilder.go Outdated Show resolved Hide resolved
x/genutil/client/cli/gentx.go Outdated Show resolved Hide resolved
x/staking/client/cli/flags.go Outdated Show resolved Hide resolved
x/staking/client/cli/flags.go Outdated Show resolved Hide resolved
@jgimeno jgimeno requested a review from alexanderbez July 6, 2020 20:44
…mos/cosmos-sdk into jonathan/genutil-viper-global-remove
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit 3c76084 into master Jul 6, 2020
@alexanderbez alexanderbez deleted the jonathan/genutil-viper-global-remove branch July 6, 2020 21:48
@alessio alessio changed the title Genutil remove global viper. remove viper global singleton from x/genutil Nov 10, 2020
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/genutil genutil module issues C:x/staking Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants