Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli test for query Account #6973

Merged
merged 33 commits into from
Aug 17, 2020
Merged

Add cli test for query Account #6973

merged 33 commits into from
Aug 17, 2020

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Aug 7, 2020

Description

Fixes #7007

This PR adds missing test for query account and refactor some tests. I see there're some tests missing for staking, gov module, which I'll add in a separate PR.
Ref: #6571


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #6973 into master will increase coverage by 0.02%.
The diff coverage is 30.43%.

@@            Coverage Diff             @@
##           master    #6973      +/-   ##
==========================================
+ Coverage   54.70%   54.73%   +0.02%     
==========================================
  Files         539      540       +1     
  Lines       36802    36812      +10     
==========================================
+ Hits        20134    20149      +15     
+ Misses      15026    15021       -5     
  Partials     1642     1642              

@sahith-narahari
Copy link
Contributor Author

@atheeshp let me know which modules you're tackling, to ensure there's no collision

@atheeshp
Copy link
Contributor

atheeshp commented Aug 7, 2020

@atheeshp let me know which modules you're tackling, to ensure there's no collision

Okay, @sahith-narahari

@sahith-narahari sahith-narahari changed the title Add missing cli tests Add cli test for query Account Aug 13, 2020
@sahith-narahari sahith-narahari mentioned this pull request Aug 13, 2020
4 tasks
@aaronc
Copy link
Member

aaronc commented Aug 13, 2020

I think this is R4R now @sahith-narahari. Can you just take a quick look through the diff and checks? I won't be able to look till later

@sahith-narahari
Copy link
Contributor Author

I think this is R4R now @sahith-narahari. Can you just take a quick look through the diff and checks? I won't be able to look till later

Sure @aaronc, I'll take it from here

baseapp/abci.go Outdated Show resolved Hide resolved
baseapp/abci.go Outdated Show resolved Hide resolved
baseapp/abci.go Outdated Show resolved Hide resolved
testutil/network/network.go Show resolved Hide resolved
x/bank/client/testutil/cli_helpers.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Although, I'd prefer to not merge this until we can get a local network running so we can play with these commands in a live manner.

@sahith-narahari sahith-narahari added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 16, 2020
@sahith-narahari sahith-narahari removed the A:automerge Automatically merge PR once all prerequisites pass. label Aug 16, 2020
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending tests pass

@alessio alessio merged commit 77124da into master Aug 17, 2020
@alessio alessio deleted the sahith/add-query-clitests branch August 17, 2020 12:47
@alexanderbez
Copy link
Contributor

@alessio localnet still doesn't work and I wanted to test this before merging.

@alessio
Copy link
Contributor

alessio commented Aug 17, 2020

Alright, @alexanderbez I can revert it if you think it'd better so

@alessio
Copy link
Contributor

alessio commented Aug 17, 2020

@alexanderbez actually @sahith-narahari is working on a fix here: #7069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Query Failure
6 participants