Change `address` from bytes to bech32 strings #7242

anilcse · 2020-09-04T22:26:15Z

Description

closes: #7195

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

amaury1093

I think this PR is on a good path. I just have a question about casttype.

proto/cosmos/distribution/v1beta1/query.proto

proto/cosmos/crisis/v1beta1/tx.proto

…m1314/cosmos-sdk into anil/7195_bech32_addresses # Conflicts: # x/distribution/keeper/grpc_query_test.go

…bech32_addresses # Conflicts: # proto/ibc/channel/channel.proto # proto/ibc/connection/connection.proto # x/distribution/types/distribution.pb.go # x/ibc-transfer/types/transfer.pb.go # x/ibc/02-client/types/client.pb.go # x/ibc/03-connection/types/connection.pb.go # x/ibc/04-channel/types/channel.pb.go # x/staking/types/staking.pb.go

clevinson · 2020-09-08T19:56:05Z

Is there a reason this PR also introduces .clang-format ? Seems to really blow up the diff size with a lot of unrelated formatting changes.

anilcse · 2020-09-08T20:02:38Z

Is there a reason this PR also introduces .clang-format ? Seems to really blow up the diff size with a lot of unrelated formatting changes.

No strong reason but having a tool/configuration for format would be handy, may be I can split that into a separate PR. I am using clang-format locally as there's no other formatting tool configured with SDK. If you have any other recommendations, please let me know. I can revert irrelavant changes from this PR and create a separate PR

alexanderbez · 2020-09-08T20:29:30Z

clang-format is a must for formatting proto files, but it should be done in a separate PR (which we can merge before this one).

amaury1093 · 2020-09-22T10:55:49Z

I saw you removed interfacer, do you know what are the linting errors related to?

anilcse · 2020-09-22T10:57:56Z

I saw you removed interfacer, do you know what are the linting errors related to?

There are a few //nolint interfacer declarations previously, its failing there. May be I will revert interfacer and add //nolint wherever we need to ignore this rule.

…bech32_addresses # Conflicts: # proto/cosmos/tx/signing/v1beta1/signing.proto # x/auth/client/rest/rest_test.go

x/staking/client/rest/grpc_query_test.go

amaury1093

This looks like it's ready to be merged! Nice work here @anilcse and @atheeshp!

…bech32_addresses

…bech32_addresses # Conflicts: # proto/cosmos/auth/v1beta1/auth.proto # x/auth/types/account.go # x/auth/types/auth.pb.go # x/staking/handler_test.go

* init * Fix bank proto messages * missing conversions * remove casttype for addresses * Fix tests * Fix consaddress * more test fixes * Fix tests * fixed tests * migrate missing proto declarations * format * Fix format * Fix alignment * Fix more tests * Fix ibc merge issue * Fix fmt * Fix more tests * Fix missing address declarations * Fix staking tests * Fix more tests * Fix config * fixed tests * Fix more tests * Update staking grpc tests * Fix merge issue * fixed failing tests in x/distr * fixed sim tests * fixed failing tests * Fix bugs * Add logs * fixed slashing issue * Fix staking grpc tests * Fix all bank tests :) * Fix tests in distribution * Fix more tests in distr * Fix slashing tests * Fix statking tests * Fix evidence tests * Fix gov tests * Fix bug in create vesting account * Fix test * remove fmt * fixed gov tests * fixed x/ibc tests * fixed x/ibc-transfer tests * fixed staking tests * fixed staking tests * fixed test * fixed distribution issue * fix pagination test * fmt * lint * fix build * fix format * revert tally tests * revert tally tests * lint * Fix sim test * revert * revert * fixed tally issue * fix tests * revert * fmt * refactor * remove `GetAddress()` * remove fmt * revert fmt.Striger usage * Fix tests * Fix rest test * disable interfacer lint check * make proto-format * add nolint rule * remove stray println Co-authored-by: aleem1314 <aleem.md789@gmail.com> Co-authored-by: atheesh <atheesh@vitwit.com>

anilcse added 6 commits September 3, 2020 22:57

init

26e073b

Fix bank proto messages

75eeedb

missing conversions

0ec8ca7

remove casttype for addresses

9c8a377

Fix tests

3a70370

Fix consaddress

8f34a1d

anilcse changed the title ~~Chnage address from bytes to bech32 strings~~ Change address from bytes to bech32 strings Sep 4, 2020

anilcse and others added 2 commits September 5, 2020 15:00

more test fixes

163a0c5

Fix tests

5dc43f4

amaury1093 reviewed Sep 7, 2020

View reviewed changes

proto/cosmos/distribution/v1beta1/query.proto Outdated Show resolved Hide resolved

proto/cosmos/crisis/v1beta1/tx.proto Outdated Show resolved Hide resolved

atheeshp and others added 14 commits September 7, 2020 16:52

fixed tests

318ffa2

Merge branch 'aleem/7195_bech32_addresses' of https://github.com/alee…

0a18f3c

…m1314/cosmos-sdk into anil/7195_bech32_addresses # Conflicts: # x/distribution/keeper/grpc_query_test.go

migrate missing proto declarations

948e8cb

format

29bf12c

Fix format

2f9990f

Fix alignment

f0f8447

Fix more tests

ede4ef6

Fix ibc merge issue

dfe122a

Fix fmt

aa0349f

Fix more tests

444ae5a

Fix missing address declarations

1d48be4

Fix staking tests

48910b5

Fix more tests

f119317

anilcse added C:Encoding T: Proto Breaking Protobuf breaking changes: generally don't do this! C:Types labels Sep 8, 2020

anilcse added 3 commits September 20, 2020 20:43

Fix rest test

f6a950f

disable interfacer lint check

2644a16

make proto-format

99f6318

anilcse added 4 commits September 23, 2020 14:01

Merge branch 'master' of github.com:cosmos/cosmos-sdk into anil/7195_…

ae1579e

…bech32_addresses # Conflicts: # proto/cosmos/tx/signing/v1beta1/signing.proto # x/auth/client/rest/rest_test.go

Merge branch 'master' into anil/7195_bech32_addresses

9f9c013

add nolint rule

f223324

Merge branch 'master' into anil/7195_bech32_addresses

f564113

amaury1093 reviewed Sep 23, 2020

View reviewed changes

x/staking/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved

amaury1093 approved these changes Sep 23, 2020

View reviewed changes

anilcse added 2 commits September 23, 2020 20:32

remove stray println

8c2c035

Merge branch 'master' into anil/7195_bech32_addresses

29f703d

sahith-narahari approved these changes Sep 23, 2020

View reviewed changes

anilcse added 2 commits September 24, 2020 01:10

Merge branch 'master' of github.com:cosmos/cosmos-sdk into anil/7195_…

1c81257

…bech32_addresses

Merge branch 'master' into anil/7195_bech32_addresses

72c8c66

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 25, 2020

Merge branch 'master' of github.com:cosmos/cosmos-sdk into anil/7195_…

03fc53e

…bech32_addresses # Conflicts: # proto/cosmos/auth/v1beta1/auth.proto # x/auth/types/account.go # x/auth/types/auth.pb.go # x/staking/handler_test.go

mergify bot merged commit d55c1a2 into master Sep 25, 2020

mergify bot deleted the anil/7195_bech32_addresses branch September 25, 2020 10:25

anilcse mentioned this pull request Sep 25, 2020

Add fee payer to protobuf definition #7384

Merged

9 tasks

fedekunze mentioned this pull request Sep 29, 2020

Upgrade Client #7367

Merged

9 tasks

This was referenced Sep 30, 2020

Cosmos SDK v1.0 Roadmap #7421

Closed

Do Proper Ocaps for x/bank (or not): A Case Study #7093

Closed

Refactor global sdk.Config #7448

Open

ssandeep mentioned this pull request Nov 19, 2020

Changing all addresses to string instead of bytes in new-heimdall maticnetwork/heimdall#413

Closed

amaury1093 mentioned this pull request Dec 7, 2020

change TmService's validator pubkey type to any #8060

Merged

9 tasks

tnasu mentioned this pull request Jul 14, 2022

Should use sdk.ConsAddressFromBech32 in x/slashing? #12573

Closed

4 tasks

coderabbitai bot mentioned this pull request Nov 27, 2023

refactor(types,client)!: refactor global address sdk.Config #18372

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change `address` from bytes to bech32 strings #7242

Change `address` from bytes to bech32 strings #7242

anilcse commented Sep 4, 2020

amaury1093 left a comment

clevinson commented Sep 8, 2020

anilcse commented Sep 8, 2020

alexanderbez commented Sep 8, 2020 •

edited

Loading

amaury1093 commented Sep 22, 2020

anilcse commented Sep 22, 2020

amaury1093 left a comment

Change address from bytes to bech32 strings #7242

Change address from bytes to bech32 strings #7242

Conversation

anilcse commented Sep 4, 2020

Description

amaury1093 left a comment

Choose a reason for hiding this comment

clevinson commented Sep 8, 2020

anilcse commented Sep 8, 2020

alexanderbez commented Sep 8, 2020 • edited Loading

amaury1093 commented Sep 22, 2020

anilcse commented Sep 22, 2020

amaury1093 left a comment

Choose a reason for hiding this comment

Change `address` from bytes to bech32 strings #7242

Change `address` from bytes to bech32 strings #7242

alexanderbez commented Sep 8, 2020 •

edited

Loading