Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old message PublicKey proto oneof #7390

Merged
merged 10 commits into from
Sep 29, 2020
Merged

Remove the old message PublicKey proto oneof #7390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f38ee65
Remove unused PublicKey type and update docs
blushi Sep 25, 2020
b02442d
Merge branch 'master' into marie/7357-rm-publickey
blushi Sep 25, 2020
53dbdd6
Update wording
blushi Sep 25, 2020
a57dab2
Update proto/cosmos/base/crypto/v1beta1/crypto.proto
blushi Sep 25, 2020
c5e78ec
Edit docs
blushi Sep 25, 2020
06bc18a
Move crypto.proto to multisig
blushi Sep 25, 2020
6851940
Proto linting
blushi Sep 25, 2020
88c5b7b
Update docs/architecture/adr-020-protobuf-transaction-encoding.md
blushi Sep 25, 2020
081358c
Merge branch 'master' into marie/7357-rm-publickey
mergify[bot] Sep 29, 2020
ebe3637
Update wording for Public Key Encoding
robert-zaremba Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crypto/keys/multisig/multisig_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func TestPubKeyMultisigThresholdAminoToIface(t *testing.T) {

ab, err := kmultisig.AminoCdc.MarshalBinaryLengthPrefixed(multisigKey)
require.NoError(t, err)
// like other crypto.Pubkey implementations (e.g. ed25519.PubKeyMultisigThreshold),
// like other crypto.Pubkey implementations (e.g. ed25519.PubKey),
// LegacyAminoPubKey should be deserializable into a crypto.LegacyAminoPubKey:
var pubKey kmultisig.LegacyAminoPubKey
err = kmultisig.AminoCdc.UnmarshalBinaryLengthPrefixed(ab, &pubKey)
Expand Down
Loading