Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosetta API implementation #7695

Merged
merged 289 commits into from
Jan 21, 2021
Merged

Rosetta API implementation #7695

merged 289 commits into from
Jan 21, 2021

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Oct 27, 2020

Description

This PR implements ADR 035(https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-035-rosetta-api-support.md)

ref: #7492


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jgimeno jgimeno changed the title Add rosetta server Integrate Rosetta into Stargate. Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #7695 (3b46221) into master (3257618) will decrease coverage by 0.49%.
The diff coverage is 5.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7695      +/-   ##
==========================================
- Coverage   61.91%   61.41%   -0.50%     
==========================================
  Files         609      610       +1     
  Lines       35101    35398     +297     
==========================================
+ Hits        21732    21741       +9     
- Misses      11085    11374     +289     
+ Partials     2284     2283       -1     
Impacted Files Coverage Δ
server/config/toml.go 18.18% <ø> (ø)
server/rosetta.go 0.00% <0.00%> (ø)
x/auth/tx/sigs.go 53.75% <0.00%> (-0.69%) ⬇️
x/bank/types/msgs.go 53.04% <0.00%> (-42.27%) ⬇️
x/distribution/types/msg.go 31.86% <0.00%> (-15.68%) ⬇️
x/slashing/client/rest/rest.go 100.00% <ø> (ø)
x/staking/client/rest/rest.go 100.00% <ø> (ø)
x/staking/types/msg.go 23.92% <0.00%> (-31.01%) ⬇️
server/config/config.go 41.17% <50.00%> (+1.64%) ⬆️
x/upgrade/types/plan.go 83.78% <80.00%> (ø)
... and 6 more

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 20, 2021
@alessio
Copy link
Contributor

alessio commented Jan 20, 2021

Tests are failing

@sahith-narahari
Copy link
Contributor Author

Tests are failing

resolved, @fdymylja should we wait for #8399 to be merged before merging this in?

@fdymylja
Copy link
Contributor

Tests are failing

resolved, @fdymylja should we wait for #8399 to be merged before merging this in?

There's no need.

@alessio
Copy link
Contributor

alessio commented Jan 21, 2021

Good to go. Thanks lads

@alessio alessio merged commit 57f5e96 into master Jan 21, 2021
@alessio alessio deleted the add-rosetta-master branch January 21, 2021 09:33
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Ref: cosmos#7492

Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants