Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ServiceMsg in StdTxBuilder.SetMsgs #7731

Merged
merged 5 commits into from Oct 30, 2020
Merged

Conversation

blushi
Copy link
Contributor

@blushi blushi commented Oct 29, 2020

Description

closes: #7653


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #7731 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #7731      +/-   ##
==========================================
- Coverage   54.31%   54.31%   -0.01%     
==========================================
  Files         610      610              
  Lines       38612    38621       +9     
==========================================
+ Hits        20972    20976       +4     
- Misses      15503    15508       +5     
  Partials     2137     2137              

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. C:Encoding labels Oct 30, 2020
@mergify mergify bot merged commit bd6c16b into master Oct 30, 2020
@mergify mergify bot deleted the marie/7653-servicemsg-stdtx branch October 30, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully handle ServiceMsg with StdTx
3 participants