ADR 037 Implementation: Governance Split Votes #7802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gov_split_vote
Governance split vote
antstalepresh
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7802 +/- ##
==========================================
+ Coverage 61.39% 61.43% +0.03%
==========================================
Files 656 656
Lines 37320 37526 +206
==========================================
+ Hits 22914 23055 +141
- Misses 12005 12063 +58
- Partials 2401 2408 +7
|
antstalepresh
force-pushed
the
gov_split_vote_weighted_vote
branch
from
251d8b1
to
138ae17
Compare
sunnya97
changed the title
sunnya97
force-pushed
the
gov_split_vote_weighted_vote
branch
from
c38f84a
to
56ed27a
Compare
amaury1093
reviewed
Jan 27, 2021
amaury1093
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
lgtm.
The proto-breaking change seems a bit worrying to me, but I don't really have an idea why it's showing as breaking (related: #7802 (comment))
|
It seems to not like the fact that we tried to reserve the name "option" when it was already used in past for field 3. But according to Protobuf docs, names and fields need to be reserved separately. I think this is more a mistake on the proto-breaking check logic that should handle this better. |
anilcse
reviewed
Feb 10, 2021
x/gov/client/rest/tx.go
Outdated
| @@ -22,6 +22,7 @@ func registerTxHandlers(clientCtx client.Context, r *mux.Router, phs []ProposalR | |||
| r.HandleFunc("/gov/proposals", newPostProposalHandlerFn(clientCtx)).Methods("POST") | |||
| r.HandleFunc(fmt.Sprintf("/gov/proposals/{%s}/deposits", RestProposalID), newDepositHandlerFn(clientCtx)).Methods("POST") | |||
| r.HandleFunc(fmt.Sprintf("/gov/proposals/{%s}/votes", RestProposalID), newVoteHandlerFn(clientCtx)).Methods("POST") | |||
| r.HandleFunc(fmt.Sprintf("/gov/proposals/{%s}/weightedvotes", RestProposalID), newWeightedVoteHandlerFn(clientCtx)).Methods("POST") | |||
There was a problem hiding this comment.
legacy REST is being deprecated, let's not add new legacy REST endpoints
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
tac0turtle
reviewed
Feb 12, 2021
Co-authored-by: Marko <markobaricevic3778@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the ADR proposed in #7733
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes