Launchpad: simulation: close open files, fix error checks #8226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: #8217 Closes: #6784 Thanks: @PrathyushaLakkireddy for the original patch. Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
alessio
changed the title
alessio
changed the title
fedekunze
reviewed
Dec 22, 2020
|
|
||
| folderPath := os.ExpandEnv("$HOME/.simapp/simulations") | ||
| fileName := fmt.Sprintf("%s.log", time.Now().Format("2006-01-02_15:04:05")) | ||
| folderPath := path.Join(os.ExpandEnv("$HOME"), ".simapp", "simulations") |
There was a problem hiding this comment.
why is this always simapp?
There was a problem hiding this comment.
This is used only for simulations, so it lgtm
There was a problem hiding this comment.
yeah but more apps rely on this "module", including gaia, so it would check for the .simapp directory
There was a problem hiding this comment.
Let's just use simulation
There was a problem hiding this comment.
This needs to be fixed in master first.
|
This requires approval from @fedekunze and @clevinson |
|
Pinging @fedekunze & @clevinson for approvals |
fedekunze
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #8217
Closes: #6784
Thanks: @PrathyushaLakkireddy for the original patch.
Co-authored-by: Alessio Treglia alessio@tendermint.com
Co-authored-by: Anil Kumar Kammari anil@vitwit.com
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes