Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow service Msg's to gracefully support Amino JSON #8346

Closed
aaronc opened this issue Jan 15, 2021 · 0 comments · Fixed by #8512
Closed

Allow service Msg's to gracefully support Amino JSON #8346

aaronc opened this issue Jan 15, 2021 · 0 comments · Fixed by #8512
Labels
T: Client UX T: State Machine Breaking State machine breaking changes (impacts consensus).
Milestone

Comments

@aaronc
Copy link
Member

aaronc commented Jan 15, 2021

There is a desire to migrate all CLI methods to use service Msg's (#8306), but this will mean that they no longer support amino JSON with the current signing logic.

Gracefully converting ServiceMsgs to Amino JSON is a relatively small change and simply involves casting the ServiceMsg.Request to sdk.Msg in the legacy sign mode handler and the legacy client CopyTx code.

I suggest we do this for v0.41 so that we can migrate to ServiceMsg everywhere but not break the ledger app (because SIGN_MODE_TEXTUAL likely won't be ready).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Client UX T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants