Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SigVerifiableTx.GetPubKeys to return an error #8828

Merged
merged 3 commits into from Mar 10, 2021

Conversation

robert-zaremba
Copy link
Collaborator

Description

closes: #8129


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@robert-zaremba robert-zaremba added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #8828 (ec10c1e) into master (24ed401) will decrease coverage by 0.01%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8828      +/-   ##
==========================================
- Coverage   59.45%   59.44%   -0.02%     
==========================================
  Files         563      563              
  Lines       31277    31286       +9     
==========================================
+ Hits        18597    18598       +1     
- Misses      10518    10522       +4     
- Partials     2162     2166       +4     
Impacted Files Coverage Δ
x/auth/ante/sigverify.go 73.18% <33.33%> (-1.68%) ⬇️
x/auth/tx/builder.go 74.24% <50.00%> (-2.14%) ⬇️
x/auth/legacy/legacytx/stdtx.go 80.85% <100.00%> (ø)

@alessio alessio merged commit 8f7cdaf into master Mar 10, 2021
@alessio alessio deleted the robert/txbuilder-getpubkeys branch March 10, 2021 07:16
@robert-zaremba robert-zaremba restored the robert/txbuilder-getpubkeys branch March 10, 2021 14:51
@robert-zaremba robert-zaremba deleted the robert/txbuilder-getpubkeys branch March 10, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrapper.GetPubKeys silently ignore unpacked keys
3 participants