Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosetta: more user guide and troubleshooting #9575

Closed
3 of 7 tasks
robert-zaremba opened this issue Jun 23, 2021 · 12 comments · Fixed by #9688
Closed
3 of 7 tasks

Rosetta: more user guide and troubleshooting #9575

robert-zaremba opened this issue Jun 23, 2021 · 12 comments · Fixed by #9688
Assignees
Labels
C:Rosetta Issues and PR related to Rosetta T:Docs Changes and features related to documentation.
Milestone

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Jun 23, 2021

Summary

In v0.43 release has a first production ready Rosetta client integrated. However we are missing proper documentation about the setup and best practice.

Problem Definition

When we were trying to run and integrate Rosetta, we encounter some problems. Let's have a proper guide for Rosetta API

Proposal

We should provide:

  • setup instructions
  • user guide (how to use rosetta)
  • troubleshotting

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added T:Docs Changes and features related to documentation. C:Rosetta Issues and PR related to Rosetta labels Jun 23, 2021
@robert-zaremba robert-zaremba added this to the v0.43 milestone Jun 23, 2021
@albertchon
Copy link
Contributor

We've been facing this issue #9488 with Rosetta breaking when processing a block containing a transaction that creates a new denom.

This would need to be fixed in order for Rosetta to be compatible with the Gravity bridge, as new denoms are created and minted when new ERC-20 tokens are transferred from Ethereum to the Gravity module for the first time.

@fdymylja
Copy link
Contributor

We've been facing this issue #9488 with Rosetta breaking when processing a block containing a transaction that creates a new denom.

This would need to be fixed in order for Rosetta to be compatible with the Gravity bridge, as new denoms are created and minted when new ERC-20 tokens are transferred from Ethereum to the Gravity module for the first time.

We have discussed about current Rosetta implementation issues here: regen-network/regen-ledger#352 (comment)

Regarding newly minted denoms, it's a known issue but unfortunately Coinbase is not being responsive on how to address this use case. (NOTE: this fails at rosetta-cli level only, if you query anything using the rosetta client you won't encounter any issue.)

@robert-zaremba
Copy link
Collaborator Author

We have discussed about current Rosetta implementation issues here: regen-network/regen-ledger#352

I know, @fdymylja - I think that it's better that the person who is in charge of Rosetta will handle it or re-delegate. For most of us it will be re-engineering to go through the process.

@noandrea
Copy link
Contributor

Summing up the rosetta history, the original PR that includes the Rosetta support within the cosmos-sdk supports the stargate release series.

The functionality and how to use it has been documented in the relevant ADR and in the article published by @fdymylja.
Tests are also implemented as well following the rosetta-cli specs.

The issue emerged with the regent-testnet is that the testnet was set-up with a v0.42.x version and later upgraded to a 0.43-dev version (that included the rosetta integration), but there has been a incompatible change here that caused an issue related to interpreting protobuf messages encoded before that version. (this has been pointed out by @fdymylja in the comment above)

The current status as I see is that the protofile breanking change has been rolled back yesterday (see upgrade.proto history)
and I assume now it should be possible to correctly interpret messages from versions < v0.43

Also the non-zero default fees pr had some impact with rosetta but AFAICS the issue was resolved.

Giving the fact that the upgrade.proto breaking change has been reverted, I assume that if we dump/reload the testnet node, rosetta should work without as expected.

I'll follow up on this first thing next week.

@noandrea
Copy link
Contributor

noandrea commented Jun 28, 2021

@anilcse what is the current status of the regen-devnet-6-4 ?

As mentioned before the proto files have being going through some changes and I believe at this point would be better to dump/restore the chain data from the latest v0.43 release or to restart the testnet.
What do you think @anilcse ?

@robert-zaremba do you know if any more changes are undergoing on the protobuf level?
it is somewhat difficult to test on a moving target

@clevinson
Copy link
Collaborator

@anilcse @robert-zaremba any update here? Would be great to make sure @noandrea has what he needs to make sure testing is successful.

@anilcse
Copy link
Collaborator

anilcse commented Jul 7, 2021

@anilcse @robert-zaremba any update here? Would be great to make sure @noandrea has what he needs to make sure testing is successful.

There's an issue with migration (pruning setting is causing some issues). I am still looking for a fix.

@robert-zaremba
Copy link
Collaborator Author

@noandrea We are planning small x/bank changes. We will try to to add sdk.Dec support (but not sure if this will happen). The only thing we merged is #9618 -- addition of URI and URIHash to bank.Metadata.

@robert-zaremba robert-zaremba changed the title Rosetta: more user guide and troubles Rosetta: more user guide and troubleshutting Jul 8, 2021
@robert-zaremba robert-zaremba changed the title Rosetta: more user guide and troubleshutting Rosetta: more user guide and troubleshooting Jul 8, 2021
@robert-zaremba
Copy link
Collaborator Author

For the troubleshooting section, @anilcse - could you list here (simple bullet-points) of the things we had a problem with? So future users won't have the same problems.

@anilcse
Copy link
Collaborator

anilcse commented Jul 9, 2021

For the troubleshooting section, @anilcse - could you list here (simple bullet-points) of the things we had a problem with? So future users won't have the same problems.

It found out to be an issue with our upgrade handler integration and not the issue from pruning settings. Thanks to @AmauryM . We were checking for a wrong upgrade-name for new store migrations and it caused the issue.

@robert-zaremba
Copy link
Collaborator Author

@anilcse - ok, so is there anything else to mention in the troubleshooting for the future users? If not then we can have that section empty (or not have it at all).

@anilcse
Copy link
Collaborator

anilcse commented Jul 9, 2021

We can leave it empty for now and add when we find out specific issues. For now we can mention about cross checking directory structure and simlink i.e., current binary version?

noandrea added a commit that referenced this issue Jul 13, 2021
ryanchristo added a commit that referenced this issue Jul 29, 2021
* docs(rosetta): add Rosetta documentation page

related to #9575

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* Update docs/rosetta/README.md

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

* combine with existing doc

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants