Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bank): update bank.Metadata - add URI and URIHash #9618

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

robert-zaremba
Copy link
Collaborator

Description

Closes: #9502


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc
Copy link
Member

aaronc commented Jul 1, 2021

I would also like to clean up the existing metadata related to other denom units. What do you think of converting those into true "virtual denoms" where they get converted internally for transactions and queries? This will require true decimals also.

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #9618 (6959136) into master (0027111) will increase coverage by 25.06%.
The diff coverage is 63.05%.

❗ Current head 6959136 differs from pull request most recent head 695cec2. Consider uploading reports for the commit 695cec2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9618       +/-   ##
===========================================
+ Coverage   35.48%   60.54%   +25.06%     
===========================================
  Files         332      588      +256     
  Lines       32620    37447     +4827     
===========================================
+ Hits        11575    22674    +11099     
+ Misses      19819    12781     -7038     
- Partials     1226     1992      +766     
Impacted Files Coverage Δ
client/keys/show.go 83.67% <ø> (-0.24%) ⬇️
client/keys/types.go 100.00% <ø> (+100.00%) ⬆️
client/keys/utils.go 42.85% <ø> (+2.50%) ⬆️
client/query.go 16.98% <ø> (ø)
client/rpc/block.go 10.00% <ø> (ø)
client/rpc/routes.go 100.00% <ø> (ø)
client/rpc/status.go 47.72% <ø> (ø)
client/rpc/validators.go 0.00% <ø> (ø)
client/test_helpers.go 0.00% <ø> (ø)
client/tx/factory.go 27.00% <ø> (ø)
... and 699 more

@mergify mergify bot merged commit e109d8a into master Jul 1, 2021
@mergify mergify bot deleted the robert/bank-improvements branch July 1, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add URI x/bank denom metadata
3 participants