perf: x/bank create reverse prefix for denom<->address

[alexanderbez]

• Add a reverse index x03 | <denom> | <address> -> 0
• Update DenomOwners to use the new index + an additional query for the balance

closes: #9590

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

@aaronc @AmauryM is this what you had in mind?

[aaronc]

This looks like the right direction. Thanks @alexanderbez ! We would just need to add a migration (cc @AmauryM)

[alexanderbez]

Since this is going into master, does this need a migration? (apologies if I should already know this)

[aaronc]

Yes it does

[amaury1093]

imo there are 3 things missing, which ideally should go in this PR too:

• migrations as you mentioned. Basically it'll be a x/bank/legacy/v044 new package with a MigrateStore function (see 043 for example). And also bumping the module's ConsensusVersion to 3.
• I believe InitGenesis doesn't call setBalance anymore, so we need to set this index in InitGenesis too
• updating the SPEC

[amaury1093]

I just had a look at TestSignWithMultiSignersAminoJSON, it's a out of gas error, i solved it by changing the gas limit to 200000

cosmos-sdk/testutil/testdata/tx.go

Lines 37 to 38 in a24a329

	func NewTestGasLimit() uint64 {
	return 100000

maybe the staking ones are related?

[alexanderbez]

Good catch @AmauryM. I've fixed the gas related tests. However, the only tests failing now are are certain x/staking query related ones.

[cyberbono3]

lgtm. Please fix the tests.

[alexanderbez]

Did some more debugging to no avail. Somehow using the denom prefix store is causing some of these x/staking query tests to fail. My initial guess is that the keyspace was getting collisions, but I don't see how that's possible.

[aaronc]

@AmauryM any idea on what's causing the tests to fail here?

[amaury1093]

@AmauryM any idea on what's causing the tests to fail here?

I'm having a look at this

[amaury1093]

@alexanderbez I fixed the test, it was again due to insufficient gas, take a look at 9a851f9.

Before putting automerge on, could you add a state-breaking changelog entry?

[alexanderbez]

Ohh goodness, how did I not catch this? Curious why this wasn't more obvious. In any case, yes, I'll add a changelog entry.