Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add bech32 prefix to authkeeper #9759

Merged
merged 73 commits into from Aug 25, 2021
Merged

feat!: Add bech32 prefix to authkeeper #9759

merged 73 commits into from Aug 25, 2021

Commits on Jul 21, 2021

  1. first draft

    @cyberbono3
    cyberbono3 committed Jul 21, 2021
    Copy the full SHA
    030fc2c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. tests pass

    @cyberbono3
    cyberbono3 committed Jul 23, 2021
    Copy the full SHA
    556810d View commit details
    Browse the repository at this point in the history

  2. add DefaultBech32Prefix

    @cyberbono3
    cyberbono3 committed Jul 23, 2021
    Copy the full SHA
    8ec7872 View commit details
    Browse the repository at this point in the history

  3. add comments to auth/query.proto

    @cyberbono3
    cyberbono3 committed Jul 23, 2021
    Copy the full SHA
    52ec23d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. set sdk.Bech32MainPrefix argument in NewAccountKeeeper()

    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    e636781 View commit details
    Browse the repository at this point in the history

  2. update x/auth/atlas/atlas-v0.39.1.md

    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    9788e2c View commit details
    Browse the repository at this point in the history

  3. fix TestBech32Prefix

    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    3fcd6c3 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    64f031f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into cy… 

    …berbono3/add-bech32Prefix-to-authkeeper
    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    befc823 View commit details
    Browse the repository at this point in the history

  6. gofmt

    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    413cf7a View commit details
    Browse the repository at this point in the history

  7. update atlas-v0.39.1.md

    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    d9be317 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into cyberbono3/add-bech32Prefix-to-authkeeper

    @cyberbono3
    cyberbono3 committed Jul 26, 2021
    Copy the full SHA
    1dd726b View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. draft

    @cyberbono3
    cyberbono3 committed Jul 29, 2021
    Copy the full SHA
    6a42f00 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'cyberbono3/add-bech32Prefix-to-authkeeper' of https://g… 

    …ithub.com/cosmos/cosmos-sdk into cyberbono3/add-bech32Prefix-to-authkeeper
    @cyberbono3
    cyberbono3 committed Jul 29, 2021
    Copy the full SHA
    2861b30 View commit details
    Browse the repository at this point in the history

  3. WIP applying aaron suggestions

    @cyberbono3
    cyberbono3 committed Jul 29, 2021
    Copy the full SHA
    704b006 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. tests pass

    @cyberbono3
    cyberbono3 committed Aug 2, 2021
    Copy the full SHA
    2459aa0 View commit details
    Browse the repository at this point in the history

  2. apply aaron suggestions

    @cyberbono3
    cyberbono3 committed Aug 2, 2021
    Copy the full SHA
    54945f1 View commit details
    Browse the repository at this point in the history

  3. update proto comments

    @cyberbono3
    cyberbono3 committed Aug 2, 2021
    Copy the full SHA
    5992482 View commit details
    Browse the repository at this point in the history

  4. update AddressBytesToString signature

    @cyberbono3
    cyberbono3 committed Aug 2, 2021
    Copy the full SHA
    1734485 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. add changelog entry for NewAccountKeeper API breaking change

    @cyberbono3
    cyberbono3 committed Aug 3, 2021
    Copy the full SHA
    0cae2b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. introduce ConvertAddressStringToBytes and ConvertAddressBytesToString… 

    … as AddressCodec methods
    @cyberbono3
    cyberbono3 committed Aug 4, 2021
    Copy the full SHA
    743b73c View commit details
    Browse the repository at this point in the history

  2. merge master into my branch and resolve conflicts

    @cyberbono3
    cyberbono3 committed Aug 4, 2021
    Copy the full SHA
    d602c76 View commit details
    Browse the repository at this point in the history

  3. revert unnecessary changes

    @cyberbono3
    cyberbono3 committed Aug 4, 2021
    Copy the full SHA
    0b5d411 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary code

    @cyberbono3
    cyberbono3 committed Aug 4, 2021
    Copy the full SHA
    1a552d7 View commit details
    Browse the repository at this point in the history

  5. update codec comments

    @cyberbono3
    cyberbono3 committed Aug 4, 2021
    Copy the full SHA
    366e589 View commit details
    Browse the repository at this point in the history

  6. address lint issues

    @cyberbono3
    cyberbono3 committed Aug 4, 2021
    Copy the full SHA
    ac607ee View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Update CHANGELOG.md 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    6cde687 View commit details
    Browse the repository at this point in the history

  2. Update proto/cosmos/auth/v1beta1/query.proto 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    4f84700 View commit details
    Browse the repository at this point in the history

  3. Update proto/cosmos/auth/v1beta1/query.proto 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    8d223e1 View commit details
    Browse the repository at this point in the history

  4. Update proto/cosmos/auth/v1beta1/query.proto 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    9696a52 View commit details
    Browse the repository at this point in the history

  5. Update proto/cosmos/auth/v1beta1/query.proto 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    888cf80 View commit details
    Browse the repository at this point in the history

  6. Update types/address/codec.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    afb95d5 View commit details
    Browse the repository at this point in the history

  7. Update proto/cosmos/auth/v1beta1/query.proto 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    21d3090 View commit details
    Browse the repository at this point in the history

  8. Update x/auth/keeper/keeper.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 5, 2021
    Copy the full SHA
    404b31f View commit details
    Browse the repository at this point in the history

  9. proto-gen

    @cyberbono3
    cyberbono3 committed Aug 5, 2021
    Copy the full SHA
    9c5941d View commit details
    Browse the repository at this point in the history

  10. apply reviewer comments

    @cyberbono3
    cyberbono3 committed Aug 5, 2021
    Copy the full SHA
    7b77ced View commit details
    Browse the repository at this point in the history

  11. minor fixes

    @cyberbono3
    cyberbono3 committed Aug 5, 2021
    Copy the full SHA
    acf5525 View commit details
    Browse the repository at this point in the history

  12. implement VerifyFormat

    @cyberbono3
    cyberbono3 committed Aug 5, 2021
    Copy the full SHA
    c544184 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Update CHANGELOG.md 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 6, 2021
    Copy the full SHA
    903cd03 View commit details
    Browse the repository at this point in the history

  2. Update types/address/codec.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 6, 2021
    Copy the full SHA
    3afebd7 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. fix grpc query tests

    @cyberbono3
    cyberbono3 committed Aug 9, 2021
    Copy the full SHA
    9289089 View commit details
    Browse the repository at this point in the history

  2. let VerifyAddressFormat call VerifyFormat

    @cyberbono3
    cyberbono3 committed Aug 9, 2021
    Copy the full SHA
    ecc5c3e View commit details
    Browse the repository at this point in the history

  3. gofmt

    @cyberbono3
    cyberbono3 committed Aug 9, 2021
    Copy the full SHA
    570332c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. rename address.Codec methods

    @cyberbono3
    cyberbono3 committed Aug 10, 2021
    Copy the full SHA
    aea81bc View commit details
    Browse the repository at this point in the history

  2. proto gen

    @cyberbono3
    cyberbono3 committed Aug 10, 2021
    Copy the full SHA
    3d48438 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. remove TestCustomAddressVerifier

    @cyberbono3
    cyberbono3 committed Aug 11, 2021
    Copy the full SHA
    e6ed444 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Merge branch 'master' into cyberbono3/add-bech32Prefix-to-authkeeper

    @cyberbono3
    cyberbono3 committed Aug 12, 2021
    Copy the full SHA
    e45fb18 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2021

  1. revert global GetConfig and TestCustomAddressVerifier

    @cyberbono3
    cyberbono3 committed Aug 15, 2021
    Copy the full SHA
    76f9c8a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. use sdkerrors in keeper.go

    @cyberbono3
    cyberbono3 committed Aug 17, 2021
    Copy the full SHA
    35600c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Update CHANGELOG.md 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @cyberbono3 @alexanderbez
    cyberbono3 and alexanderbez committed Aug 18, 2021
    Copy the full SHA
    e31297b View commit details
    Browse the repository at this point in the history

  2. Update types/address.go 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @cyberbono3 @alexanderbez
    cyberbono3 and alexanderbez committed Aug 18, 2021
    Copy the full SHA
    9efcf4a View commit details
    Browse the repository at this point in the history

  3. rename address codec interface methods

    @cyberbono3
    cyberbono3 committed Aug 18, 2021
    Copy the full SHA
    60cf6e7 View commit details
    Browse the repository at this point in the history

  4. move bech32_codec logic into separate file

    @cyberbono3
    cyberbono3 committed Aug 18, 2021
    Copy the full SHA
    293bdf1 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. remove VerifyFormat

    @cyberbono3
    cyberbono3 committed Aug 19, 2021
    Copy the full SHA
    31bac6d View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Update types/address/codec.go 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @cyberbono3 @alexanderbez
    cyberbono3 and alexanderbez committed Aug 20, 2021
    Copy the full SHA
    12106d3 View commit details
    Browse the repository at this point in the history

  2. Update types/address/codec.go 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @cyberbono3 @alexanderbez
    cyberbono3 and alexanderbez committed Aug 20, 2021
    Copy the full SHA
    74cdb60 View commit details
    Browse the repository at this point in the history

  3. add ref to VerifyAddressFormat TODO

    @cyberbono3
    cyberbono3 committed Aug 20, 2021
    Copy the full SHA
    49f1858 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into cy… 

    …berbono3/add-bech32Prefix-to-authkeeper
    @cyberbono3
    cyberbono3 committed Aug 20, 2021
    Copy the full SHA
    f12c44b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Update types/address/codec.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    3678bce View commit details
    Browse the repository at this point in the history

  2. Update x/auth/keeper/keeper.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    53844bb View commit details
    Browse the repository at this point in the history

  3. Fix comments

    @amaury1093
    amaury1093 committed Aug 24, 2021
    Copy the full SHA
    b3fb3bd View commit details
    Browse the repository at this point in the history

  4. Update x/auth/keeper/keeper.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    131de71 View commit details
    Browse the repository at this point in the history

  5. Update x/auth/keeper/grpc_query_test.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    b32ce72 View commit details
    Browse the repository at this point in the history

  6. Update x/auth/keeper/keeper.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    acc6675 View commit details
    Browse the repository at this point in the history

  7. Update x/auth/keeper/keeper.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    0b27c66 View commit details
    Browse the repository at this point in the history

  8. Update x/auth/keeper/grpc_query_test.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    d4267bf View commit details
    Browse the repository at this point in the history

  9. Update x/auth/keeper/grpc_query_test.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 24, 2021
    Copy the full SHA
    9aae756 View commit details
    Browse the repository at this point in the history

  10. address reviewer comments

    @cyberbono3
    cyberbono3 committed Aug 24, 2021
    Copy the full SHA
    3d2d5b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Update x/auth/keeper/keeper.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 25, 2021
    Copy the full SHA
    5d0ba44 View commit details
    Browse the repository at this point in the history

  2. Update x/auth/keeper/grpc_query_test.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 25, 2021
    Copy the full SHA
    a351a89 View commit details
    Browse the repository at this point in the history

  3. Update x/auth/keeper/grpc_query_test.go 

    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    @cyberbono3 @amaury1093
    cyberbono3 and amaury1093 committed Aug 25, 2021
    Copy the full SHA
    aa76cbc View commit details
    Browse the repository at this point in the history

  4. apply reviewer comments

    @cyberbono3
    cyberbono3 committed Aug 25, 2021
    Copy the full SHA
    fb9e5a3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into cyberbono3/add-bech32Prefix-to-authkeeper

    @amaury1093
    amaury1093 committed Aug 25, 2021
    Copy the full SHA
    4d2a866 View commit details
    Browse the repository at this point in the history