Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify staking bond_denom when creating a new chain #9776

Merged
merged 32 commits into from Jul 30, 2021

Conversation

likhita-809
Copy link
Contributor

Description

Add a flag that allows us to specify staking bond_denom when creating a new chain

ref: #9407


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@orijbot
Copy link

orijbot commented Jul 26, 2021

Visit https://dashboard.github.orijtech.com?pr=9776&repo=cosmos%2Fcosmos-sdk to see benchmark details.

@likhita-809 likhita-809 marked this pull request as ready for review July 26, 2021 16:23
@github-actions github-actions bot added C:CLI C:x/genutil genutil module issues labels Jul 26, 2021
…khita/add-stakingBondDenom-flag-to-init-chain
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #9776 (1929665) into master (d05c093) will decrease coverage by 0.00%.
The diff coverage is 35.29%.

❗ Current head 1929665 differs from pull request most recent head e7821a1. Consider uploading reports for the commit e7821a1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9776      +/-   ##
==========================================
- Coverage   63.48%   63.48%   -0.01%     
==========================================
  Files         566      566              
  Lines       53089    53104      +15     
==========================================
+ Hits        33705    33711       +6     
- Misses      17477    17485       +8     
- Partials     1907     1908       +1     
Impacted Files Coverage Δ
x/genutil/client/cli/init.go 62.61% <35.29%> (-4.78%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

…khita/add-stakingBondDenom-flag-to-init-chain
…khita/add-stakingBondDenom-flag-to-init-chain
@likhita-809 likhita-809 requested a review from ruhatch July 29, 2021 07:04
…khita/add-stakingBondDenom-flag-to-init-chain
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderbez
Copy link
Contributor

@AmauryM any interest in quickly reviewing this?

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @likhita-809! I'm not sure I like the strings.Replace, but okay to keep this solution.

I left some comments where I think we could do shorter code.

CHANGELOG.md Outdated Show resolved Hide resolved
x/genutil/client/cli/init.go Outdated Show resolved Hide resolved
x/genutil/client/cli/init.go Outdated Show resolved Hide resolved
x/genutil/client/cli/init.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better to me, thanks!

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 30, 2021
@mergify mergify bot merged commit cab727a into master Jul 30, 2021
@mergify mergify bot deleted the likhita/add-stakingBondDenom-flag-to-init-chain branch July 30, 2021 11:17
@amaury1093 amaury1093 mentioned this pull request May 20, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants