Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the invalid argument for bank total supply cli query #9980

Merged
merged 2 commits into from Aug 23, 2021
Merged

fix: fix the invalid argument for bank total supply cli query #9980

merged 2 commits into from Aug 23, 2021

Conversation

gsk967
Copy link
Contributor

@gsk967 gsk967 commented Aug 21, 2021

Description

Closes: #9977


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #9980 (1b4492c) into master (e3aec18) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9980   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files         566      566           
  Lines       53362    53362           
=======================================
+ Hits        34046    34047    +1     
+ Misses      17397    17396    -1     
  Partials     1919     1919           
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@gsk967 gsk967 marked this pull request as ready for review August 21, 2021 02:55
@anilcse anilcse added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 23, 2021
@mergify mergify bot merged commit 00f987a into cosmos:master Aug 23, 2021
@orijbot
Copy link

orijbot commented Aug 23, 2021

@amaury1093 amaury1093 mentioned this pull request May 23, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI query for total supply returns a response for incorrect argument
4 participants