Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

compability with ethers.js #349

Open
noot opened this issue Jun 30, 2020 · 3 comments
Open

compability with ethers.js #349

noot opened this issue Jun 30, 2020 · 3 comments
Assignees

Comments

@noot
Copy link
Contributor

noot commented Jun 30, 2020

Proposal: [Description of the feature]

Acceptance Criteria: resolve issue with safety check so that ethers.js is fully compatible with Ethermint.

currently, ethermint is not compatible with ethers.js due to a safety check. we need to fork ethers to remove this check and ensure that it works as usual. then attempt to get an ethermint compatible version upstreamed

Current behavior: [What currently happens]

Desired behavior: [What you would like to happen]

Use case: [Why is this important (helps with prioritizing requests)]

Requests may be closed if we're not actively planning to work on them.

@noot noot self-assigned this Jun 30, 2020
@fedekunze
Copy link
Contributor

which is the safety check? I'd prefer to avoid maintaining another fork, so if we can upstream the required changes to ethers.js that would be ideal

@noot
Copy link
Contributor Author

noot commented Jun 30, 2020

@fedekunze I believe it's here: https://github.com/ethers-io/ethers.js/blob/b288ad9ba791073df2768c580abe9173c6b851f6/providers/base-provider.js#L789-L792

yeah, not planning on maintaining our own fork, the goal is to upstream

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Jul 29, 2020
@fedekunze fedekunze added help wanted Extra attention is needed Status: On Ice Type: Enhancement and removed stale stale PRs that will be closed if no further action occurs labels Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants