Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gov Spam Prevention Mechanism #2246

Closed
5 tasks
glnro opened this issue Feb 23, 2023 · 1 comment · Fixed by #2262
Closed
5 tasks

Gov Spam Prevention Mechanism #2246

glnro opened this issue Feb 23, 2023 · 1 comment · Fixed by #2262
Assignees

Comments

@glnro
Copy link
Contributor

glnro commented Feb 23, 2023

Summary

A spike in spam gov proposals has necessitated a temporary mitigation until the Hub can upgrade to v0.47 of the SDK which will include enforceable spam prevention via the addition of a gov param for initial proposal submission deposit..

Problem Definition

At present it costs next to nothing to execute a spam attack via governance on the Hub. While the only nuisance to the chain it causes is driving a sharp increase in the gov proposal index, most of these text proposals include malicious links that have the potential to harm users who might be unaware.

Proposal

Create a new ante decorator that filters messages for MsgSubmitProposal, and returns an error if the minimum deposit threshold is not met. This MinInitialDeposit can be a hard amount, or a percentage of the MinDeposit. Current MinDeposit is 250000000uatom. Something like 10% would put the price to submit a proposal between 300-350$ at the time of writing.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@RaulBernal
Copy link

RaulBernal commented Feb 28, 2023

Hello, we did it for our v0.45 chain following some example from Juno and works perfectly:

BitCannaGlobal/bcna#146
thanks to @vuong177

@mpoke mpoke assigned MSalopek and unassigned jtremback, mpoke, sainoe and yaruwangway Mar 3, 2023
@mpoke mpoke added this to the Next patch release milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

7 participants