Querying signing-infos for genesis validators outputs the struct with empty address field

[puneet2019]

Summary of Bug

Querying signing-info for genesis validators outputs the struct with empty address field.

Version

Latest mainnet, v13

Steps to Reproduce

i guess validators with startheight: 0 have no address mentioned in signing-info ( genesis validators? )
checked for figment:
gaiad q staking validator cosmosvaloper1hjct6q7npsspsg3dgvzk3sdf89spmlpfdn6m9d --node https://cosmos-rpc.polkachu.com:443

gaiad q slashing signing-info '{"@type":"/cosmos.crypto.ed25519.PubKey","key":"n9bW9hmvwSwm/AnJtDwZNGA+2RSoQsfoMFsc2Rrb0vY="}' --node https://cosmos-rpc.polkachu.com:443

{"address":"","start_height":"0","index_offset":"21165260","jailed_until":"1970-01-01T00:00:00Z","tombstoned":false,"missed_blocks_counter":"22"}

for post genesis validators - created using create-validator command.
gaiad q staking validator cosmosvaloper1udpsgkgyutgsglauk9vk9rs03a3skc62gup9ny --node https://cosmos-rpc.polkachu.com:443

gaiad q slashing signing-info '{"@type":"/cosmos.crypto.ed25519.PubKey","key":"idewuO7ku3PO7LWarS4WNUPvvAZVgOTYMbyPqtcltlg="}' --node https://cosmos-rpc.polkachu.com:443

{"address":"cosmosvalcons19f07eunv876rgf4vdv7mtzj6h3vqpu4qtedw05","start_height":"231548","index_offset":"15623695","jailed_until":"1970-01-01T00:00:00Z","tombstoned":false,"missed_blocks_counter":"0"}

Is this a bug?

Not a blocking bug, because it outputs correct information for singular signing-info query just that the address is missing.
And if one wants to query all signing-infos so that one can match them with all validators, it becomes impossible.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned
• Is a spike necessary to map out how the issue should be approached?

[mpoke]

@puneet2019 Thanks for opening the issue. I believe though that this is a duplicate of #1734. Could you please confirm?

[puneet2019]

@mpoke Ah yes! it is. it seems so old, any idea if it will ever be taken up?

[puneet2019]

i believe

		keepers.SlashingKeeper.IterateValidatorSigningInfos(ctx,
			func(addr sdk.ConsAddress, info slashingtypes.ValidatorSigningInfo) bool {
				if info.Address == "" {
					info.Address = addr.String()
				}
				keepers.SlashingKeeper.SetValidatorSigningInfo(ctx, addr, info)
				return false
			})

in any upgrade instruction should do the job?

[mpoke]

any idea if it will ever be taken up?

@puneet2019 Not sure. It's not high on our priority list as we are not aware of it being an issue for users. If it's something that you need, please let us know so we can increase the priority.

I'll close this issue as a duplicate. Let's move the discussion to #1734.

[puneet2019]

yes @mpoke #1734 (comment)
this seems important enough, we could be querying all validators and matching with all-signing infos.
But it to do it in a loop for all 180 on archival node is quite expensive.