rules/sdk: more accurately determine overflow for *int*(len(...)) by type & 32/64-bit architectures #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
force-pushed
the
rules-sdk-correctly-check-len-end-conversions-by-machine-architecture
branch
from
036b42b
to
2d50c9c
Compare
…type & 32/64-bit architectures Depending on the machine that the rule is being run on, determine if the result of an integer cast to len(value) will overflow e.g. * int8, uint8, int16, uint16 (len(value)) will always overflow on 32/64-bits * uint32(len(value)) shall overflow on 64-bit machines but not on 32-bit * int64(len(value)) cannot overflow on 64-bit machines nor on 32-bit * int(len(value)) cannot overflow on either 64-bit or 32-bit machines * uint(len(value)) cannot overflow on either 64-bit or 32-bit machines Fixes #54
odeke-em
force-pushed
the
rules-sdk-correctly-check-len-end-conversions-by-machine-architecture
branch
from
2d50c9c
to
7457825
Compare
odeke-em
deleted the
rules-sdk-correctly-check-len-end-conversions-by-machine-architecture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the machine that the rule is being run on, determine if the result of an integer cast to len(value) will overflow e.g.
Fixes #54