R4R: Use new tendermint/libs/db.DB.ReverseIterator API #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ValarDragon
reviewed
Nov 26, 2018
| @@ -1,4 +1,4 @@ | |||
| package iavl | |||
|
|
|||
| // Version of iavl. | |||
| const Version = "0.11.1" | |||
There was a problem hiding this comment.
this is a breaking change, so it should be 0.12.0 right?
There was a problem hiding this comment.
Is it really? What's breaking in the IAVL here? The GoAPI of the underlying db lib went through breaking change, but doesn't seem like there's a breaking change in this PR?
There was a problem hiding this comment.
Does IAVL only work with a given db implementation? My understanding was that it took in an interface, so others can in principle have supplied their own db implementation here.
ridenaio
pushed a commit
to idena-network/iavl
that referenced
this pull request
Jul 1, 2019
* Use new tendermint/libs/db.DB.ReverseIterator API * Bump version * ... * update to tendermint v0.27.0-dev1 * breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tendermint/tendermint#2913