WIP: Improve benchmarks

benchmarks/bench_test.go

@@ -18,7 +18,7 @@ func randBytes(length int) []byte {
 	return key
 }
 
-func prepareTree(db db.DB, size, keyLen, dataLen int) (*iavl.VersionedTree, [][]byte) {
+func prepareTree(b *testing.B, db db.DB, size, keyLen, dataLen int) (*iavl.VersionedTree, [][]byte) {
 	t := iavl.NewVersionedTree(size, db)
 	keys := make([][]byte, size)
 
@@ -27,12 +27,27 @@ func prepareTree(db db.DB, size, keyLen, dataLen int) (*iavl.VersionedTree, [][]
 		t.Set(key, randBytes(dataLen))
 		keys[i] = key
 	}
-	t.Hash()
-	t.SaveVersion(t.LatestVersion() + 1)
+	commitTree(b, t)
 	runtime.GC()
 	return t, keys
 }
 
+// commit tree saves a new version and deletes and old one...
+func commitTree(b *testing.B, t *iavl.VersionedTree) {
+	t.Hash()
+	version := t.LatestVersion()
+	_, err := t.SaveVersion(version + 1)
+	if err != nil {
+		b.Errorf("Can't save: %v", err)
+	}
+	if version > 1 {
+		err = t.DeleteVersion(version - 1)
+		if err != nil {
+			b.Errorf("Can't delete: %v", err)
+		}
+	}
+}
+
 func runQueries(b *testing.B, t *iavl.VersionedTree, keyLen int) {
 	for i := 0; i < b.N; i++ {
 		q := randBytes(keyLen)
@@ -65,8 +80,7 @@ func runUpdate(b *testing.B, t *iavl.VersionedTree, dataLen, blockSize int, keys
 		key := keys[rand.Int31n(l)]
 		t.Set(key, randBytes(dataLen))
 		if i%blockSize == 0 {
-			t.Hash()
-			t.SaveVersion(t.LatestVersion() + 1)
+			commitTree(b, t)
 		}
 	}
 	return t
@@ -81,8 +95,7 @@ func runDelete(b *testing.B, t *iavl.VersionedTree, blockSize int, keys [][]byte
 		// TODO: test if removed, use more keys (from insert)
 		t.Remove(key)
 		if i%blockSize == 0 {
-			t.Hash()
-			t.SaveVersion(t.LatestVersion() + 1)
+			commitTree(b, t)
 		}
 	}
 	return t
@@ -96,7 +109,7 @@ func runBlock(b *testing.B, t *iavl.VersionedTree, keyLen, dataLen, blockSize in
 
 	lastCommit := t
 	real := t
-	check := t
+	// check := t
 
 	for i := 0; i < b.N; i++ {
 		for j := 0; j < blockSize; j++ {
@@ -110,15 +123,14 @@ func runBlock(b *testing.B, t *iavl.VersionedTree, keyLen, dataLen, blockSize in
 			data := randBytes(dataLen)
 
 			// perform query and write on check and then real
-			check.Get(key)
-			check.Set(key, data)
+			// check.Get(key)
+			// check.Set(key, data)
 			real.Get(key)
 			real.Set(key, data)
 		}
 
 		// at the end of a block, move it all along....
-		real.Hash()
-		real.SaveVersion(real.LatestVersion() + 1)
+		commitTree(b, real)
 		lastCommit = real
 	}
 
@@ -214,7 +226,7 @@ func runBenchmarks(b *testing.B, benchmarks []benchmark) {
 		defer func() {
 			err := os.RemoveAll(dirName)
 			if err != nil {
-				fmt.Printf("%+v\n", err)
+				b.Errorf("%+v\n", err)
 			}
 		}()
 
@@ -244,7 +256,7 @@ func runSuite(b *testing.B, d db.DB, initSize, blockSize, keyLen, dataLen int) {
 	runtime.GC()
 	init := memUseMB()
 
-	t, keys := prepareTree(d, initSize, keyLen, dataLen)
+	t, keys := prepareTree(b, d, initSize, keyLen, dataLen)
 	used := memUseMB() - init
 	fmt.Printf("Init Tree took %0.2f MB\n", used)
 
@@ -265,15 +277,15 @@ func runSuite(b *testing.B, d db.DB, initSize, blockSize, keyLen, dataLen int) {
 
 	// both of these edit size of the tree too much
 	// need to run with their own tree
-	t = nil // for gc
-	b.Run("insert", func(sub *testing.B) {
-		it, _ := prepareTree(d, initSize, keyLen, dataLen)
-		sub.ResetTimer()
-		runInsert(sub, it, keyLen, dataLen, blockSize)
-	})
-	b.Run("delete", func(sub *testing.B) {
-		dt, dkeys := prepareTree(d, initSize+sub.N, keyLen, dataLen)
-		sub.ResetTimer()
-		runDelete(sub, dt, blockSize, dkeys)
-	})
+	// t = nil // for gc
+	// b.Run("insert", func(sub *testing.B) {
+	// 	it, _ := prepareTree(d, initSize, keyLen, dataLen)
+	// 	sub.ResetTimer()
+	// 	runInsert(sub, it, keyLen, dataLen, blockSize)
+	// })
+	// b.Run("delete", func(sub *testing.B) {
+	// 	dt, dkeys := prepareTree(d, initSize+sub.N, keyLen, dataLen)
+	// 	sub.ResetTimer()
+	// 	runDelete(sub, dt, blockSize, dkeys)
+	// })
 }