DeleteVersions #271
Merged
DeleteVersions #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
T:enhancement
erikgrinaker
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
LGTM. Let's merge this as a first API, we may not want to hold up the next release over the optimizations since they're not totally trivial and could take a couple of days to get right.
Would be great to have the dependency changes split out as a separate PR though.
|
That was just the result of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
MutableTree#DeleteVersions. This method will be used in the revised pruning strategy in the Cosmos SDK, where pruned versions will be deleted in "batches" as opposed to on a block-by-block basis.@erikgrinaker feel free to keep this PR open while you tackle removing pruning from the IAVL as I know you'll also further optimize this method. Or you can also merge this and address optimizations later.
/cc @zmanian