fix overflow-related out-of-bounds panic in decodeBytes() #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
approved these changes
Dec 13, 2020
There was a problem hiding this comment.
Thank you @erikgrinaker!
The end < n + s >= maxInt || size < 0 checks effectively curtail the problems. For tests, perhaps we can use the original bug report as well as another case of using (1<<63 - 2), and any byte slice of length 3 and above.
erikgrinaker
changed the title
tac0turtle
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339, again -- the previous fix had another overflow issue causing out of bounds errors. 🤦♂️ See issue for details.
Would appreciate thorough reviews to make sure this is solid.