Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 027: Add support for WASM based light client #163

Merged
merged 5 commits into from
May 12, 2021
Merged

ADR 027: Add support for WASM based light client #163

merged 5 commits into from
May 12, 2021

Conversation

ParthDesai
Copy link
Contributor

Description

This PR is new version of: cosmos/cosmos-sdk#8035

cc: @colin-axner

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

colin-axner
colin-axner approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

Could you add a link to the README under docs/architecture?

AdityaSripal
AdityaSripal approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, have a few grammar points. Precise details on clientstate functions should be ironed out in implementation, but general proposal is good!

docs/architecture/adr-027-ibc-wasm.md Outdated Show resolved Hide resolved
docs/architecture/adr-027-ibc-wasm.md Outdated Show resolved Hide resolved
docs/architecture/adr-027-ibc-wasm.md
existing IBC light clients as well as adding support for new IBC light clients without requiring a code release and corresponding
hard-fork event.

## Context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great context section!!

@fedekunze @AdityaSripal
Apply suggestions from code review
ed3b0e5 
Co-authored-by: Aditya <adityasripal@gmail.com>
fedekunze
fedekunze approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@colin-axner colin-axner enabled auto-merge (squash) May 12, 2021 11:35
@colin-axner colin-axner merged commit 6dbf32f into cosmos:main May 12, 2021
@mkaczanowski mkaczanowski mentioned this pull request Jun 1, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@colin-axner colin-axner colin-axner approved these changes

@fedekunze fedekunze fedekunze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ParthDesai @AdityaSripal @colin-axner @fedekunze