Fixing semver version check in e2e #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Sep 20, 2022
Comment on lines
+23
to
+32
| "chain-a-tag": "v0.3.3", | ||
| "chain-b-tag": "v0.3.3" | ||
| }, | ||
| { | ||
| "chain-a-tag": "v0.2.3", | ||
| "chain-b-tag": "v0.2.3" | ||
| }, | ||
| { | ||
| "chain-a-tag": "v0.1.4", | ||
| "chain-b-tag": "v0.1.4" |
There was a problem hiding this comment.
added tests which run against the same version
chatton
commented
Sep 20, 2022
| @@ -0,0 +1,58 @@ | |||
| [ | |||
There was a problem hiding this comment.
added this separate matrix which allows us to just run icad tests
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
colin-axner
approved these changes
Sep 20, 2022
damiannolan
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following was produced by running
Using the new test matrix added.
Backwards compatibility tests
Matrix Version: icad
TestInterchainAccountsTestSuite
TestIncentivizedInterchainAccountsTestSuite
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes