Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keep containers configurable #6795

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jul 10, 2024

Description

When running a full test suite, we need to keep the containers around after a test finishes so as to not interfere with other tests. For local development it can be handy to still clean up containers after a single test.

This PR adds a config value to enable this.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Jul 10, 2024

Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Such a quick turnaround <3

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should ever consider using https://github.com/spf13/viper for managing the configs and env vars. There's a lot of nice convenience methods for handling bools etc.

I think the config as it exists now works pretty good tho!

@chatton
Copy link
Contributor Author

chatton commented Jul 10, 2024

Wonder if we should ever consider using https://github.com/spf13/viper for managing the configs and env vars. There's a lot of nice convenience methods for handling bools etc.

I think the config as it exists now works pretty good tho!

definitely worth considering I think! The env configuration is not ideal for local use but I think works nicely in CI, however we can probably get viper working nicely in CI too and not needing to propagate envs the same way we do now.

@chatton chatton added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 350d124 Jul 10, 2024
79 checks passed
@chatton chatton deleted the cian/gjermund/make-keep-containers-configurable branch July 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants