Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the ibc-primitives crate #1327

Open
1 task
seanchen1991 opened this issue Aug 29, 2024 · 0 comments
Open
1 task

Deprecate the ibc-primitives crate #1327

seanchen1991 opened this issue Aug 29, 2024 · 0 comments
Assignees
@seanchen1991
Labels
dependencies Pull requests that update a dependency file O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone
v1

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Aug 29, 2024 •
edited
Loading

Feature Summary

As mentioned in this comment, the types that live under ibc-primitives are mostly host-related utilities that would be more appropriate living under the ics24-host crate.

Additionally, the boundary of what should and should not be included in ibc-primitives is not clear. As a result, we should consider deprecating the ibc-primitives crate and finding appropriate workspaces for its types to reside in.

Proposal

  • Deprecate the ibc-primitives crate
@seanchen1991 seanchen1991 added dependencies Pull requests that update a dependency file O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding labels Aug 29, 2024
@seanchen1991 seanchen1991 added this to the v1 milestone Aug 29, 2024
@seanchen1991 seanchen1991 self-assigned this Aug 29, 2024
@seanchen1991 seanchen1991 changed the title Deprecate the ibc-primitivescrate Deprecate the ibc-primitives crate Aug 29, 2024
This was referenced Sep 19, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanchen1991 seanchen1991

Labels
dependencies Pull requests that update a dependency file O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
ibc-rs
Status: 📥 To Do
Milestone
v1
Development

No branches or pull requests
1 participant
@seanchen1991