Call delete_packet_commitment instead of delete_packet_acknowledgement after receiving acknowledgement packets

[livelybug]

Crate

modules

Summary of Bug

After reading the comments in ibc-go:
// if packet commitment still exists on the original sending chain, then packet ack has not been received
// since processing the ack will delete the packet commitment

I think the corresponding logic in ibc-rs may need to adjust accordingly:
After receiving acknowledgement packets from the relayer via an unordered channel, the chain should call delete_packet_commitment, instead of delete_packet_acknowledgement

Otherwise, the query_unreceived_acknowledgement is possible to return the ack packets already received.

Version

ac68782

Steps to Reproduce

• Start 2 substrate chains chain_a and chain_b;
• Start the Hermes relayer monitoring the 2 chains above;
• chain_a emits a SendPacket event;
• The event is relayed by the relayer to chain_b;
• chain_b emits a WriteAck event;
• The relayer detects the WriteAck event;
• The relayer sends ack packets to chain_a repeatedly every time it detects a new block event;

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[hu55a1n1]

Thanks for opening this issue @livelybug! Nice catch! 👌