Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel closing handshake alterations #136

Closed
cwgoes opened this issue Jun 25, 2019 · 3 comments · Fixed by #144
Closed

Channel closing handshake alterations #136

cwgoes opened this issue Jun 25, 2019 · 3 comments · Fixed by #144
Assignees
@cwgoes
Labels
tao Transport, authentication, & ordering layer.
Milestone
IBC 1.0.0-rc3

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jun 25, 2019

Split off from #126.

  • Channel closing handshake should be able to specify a "reason" for closure.
  • Modules should be able to register handlers on closures for specific reasons (e.g. fraud).
@cwgoes cwgoes added the tao Transport, authentication, & ordering layer. label Jun 25, 2019
@cwgoes cwgoes self-assigned this Jun 25, 2019
@cwgoes cwgoes mentioned this issue Jun 25, 2019
Closed
10 tasks
@cwgoes cwgoes added this to the Specification Clarification milestone Jun 25, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 29, 2019

The latter "handler registering" should happen through ICS 26 (ref #134).

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 29, 2019

Ways in which channels are closed:

  • Channel closing handshake
  • By timeout, for ordered channels
  • By equivocation

Anything else?

@cwgoes cwgoes mentioned this issue Jul 4, 2019
Merged
@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 4, 2019

I think the simple thing of "if other channel end is closed, close mine too" will be best here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
IBC 1.0.0-rc3
Development

Successfully merging a pull request may close this issue.

Channel ordering; acknowledgements; closing handshake changes; general clarification cosmos/ibc
1 participant
@cwgoes