ICS3 protocol fix for version negotiation #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwgoes
suggested changes
Sep 2, 2020
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
cwgoes
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
ACK
I think it may be worth noting that if the two chains implement different pickVersion functions, a (possibly misbehaving) relayer may be able to stall the handshake by doing INIT - OPENTRY on both chains (at which point they will pick different versions and be unable to continue).
cwgoes
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution candidate to close #459.
For a full discussion on the underlying problem, see ibc-rs/disclosure-log.