Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Cryptographic verification of equivocation #1287

Merged
merged 13 commits into from
Sep 14, 2023

Commits on Aug 14, 2023

  1. feat!: add ICS misbehaviour handling (#826)

    * define msg to submit misbehaviour to provider
    
    implement msg handling logic
    
    e2e test msg handling logic
    
    * wip: get byzantine validators in misbehavioiur handling
    
    * add tx handler
    
    * format HandleConsumerMisbehaviour
    
    * add tx handler
    
    * add debugging stuff
    
    * Add misbehaviour handler
    
    * create message for consumer double voting evidence
    
    * add DRAFT double vote handler
    
    * Add cli cmd for submit consumer double voting
    
    * Add double-vote handler
    
    * add last update
    
    * fix jailing
    
    * pass first jailing integration test
    
    * format tests
    
    * doc
    
    * save
    
    * update e2e tests'
    
    * fix typo and improve docs
    
    * remove unwanted tm evidence protofile
    
    * fix typos
    
    * update submit-consumer-misbehaviour cli description
    
    * check that header1 and header2 have the same TrustedValidators
    
    * feat: add e2e tests for ICS misbehaviour (#1118)
    
    * remove unwanted changes
    
    * fix hermes config with assigned key
    
    * revert unwanted changes
    
    * revert local setup
    
    * remove log file
    
    * typo
    
    * update doc
    
    * update ICS misbehaviour test
    
    * update ICS misbehaviour test
    
    * revert mixed commits
    
    * add doc
    
    * lint
    
    * update to handle only equivocations
    
    * improve doc
    
    * update doc
    
    * update E2E tests comment
    
    * optimize signatures check
    
    * doc
    
    * update e2e tests
    
    * linter
    
    * remove todo
    
    * Feat: avoid race condition in ICS misbehaviour handling (#1148)
    
    * remove unwanted changes
    
    * fix hermes config with assigned key
    
    * revert unwanted changes
    
    * revert local setup
    
    * remove log file
    
    * typo
    
    * update doc
    
    * update ICS misbehaviour test
    
    * update ICS misbehaviour test
    
    * revert mixed commits
    
    * update ICS misbehaviour test
    
    * update ICS misbehaviour test
    
    * Add test for MsgSubmitConsumerMisbehaviour parsing
    
    * fix linter
    
    * save progress
    
    * add CheckMisbehaviourAndUpdateState
    
    * update integration tests
    
    * typo
    
    * remove e2e tests from another PRs
    
    * cleaning'
    
    * Update x/ccv/provider/keeper/misbehaviour.go
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    
    * Update x/ccv/provider/keeper/misbehaviour.go
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    
    * update integration tests
    
    * save
    
    * save
    
    * nits
    
    * remove todo
    
    * lint
    
    * Update x/ccv/provider/keeper/misbehaviour.go
    
    ---------
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    Co-authored-by: Marius Poke <marius.poke@posteo.de>
    
    * Update x/ccv/provider/client/cli/tx.go
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    
    * Update x/ccv/provider/client/cli/tx.go
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    
    * add attributes to EventTypeSubmitConsumerMisbehaviour
    
    * Update x/ccv/provider/keeper/misbehaviour.go
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    
    * Update x/ccv/provider/keeper/misbehaviour.go
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    
    * apply review suggestions
    
    * fix docstring
    
    * Update x/ccv/provider/keeper/misbehaviour.go
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    
    * fix link
    
    * apply review suggestions
    
    * update docstring
    
    ---------
    
    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    Co-authored-by: Marius Poke <marius.poke@posteo.de>
    3 people committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    a77eea1 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. feat: improve ICS misbehaviour E2E testing coverage (#1225)

    * update e2e tests
    
    * update the chain halt assertion
    sainoe committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    21e3d83 View commit details
    Browse the repository at this point in the history
  2. refactor: address comments of ICS Misbehaviour PRs #826 and #1148 (#1223

    )
    
    * remove interface
    
    * improve comment
    
    * update godoc
    
    * address last comments
    sainoe committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    292ad75 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. feat: add handler for consumer double voting (#1232)

    * create new endpoint for consumer double voting
    
    * add first draft handling logic
    
    * first iteration of double voting
    
    * draft first mem test
    
    * error handling
    
    * refactor
    
    * add unit test of double voting verification
    
    * remove evidence age checks
    
    * document
    
    * doc
    
    * protogen
    
    * reformat double voting handling
    
    * logger nit
    
    * nits
    
    * check evidence age duration
    
    * move verify double voting evidence to ut
    
    * fix nit
    
    * nits
    
    * fix e2e tests
    
    * improve double vote testing coverage
    
    * remove TODO
    
    * lint
    
    * add UT for JailAndTombstoneValidator
    
    * nits
    
    * nits
    
    * remove tombstoning and evidence age check
    
    * lint
    
    * typo
    
    * improve godoc
    sainoe committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f168b9b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. fix: tiny bug in NewSubmitConsumerDoubleVotingCmd (#1247)

    * fix double voting cli
    
    * fix bug double signing handler
    
    * godoc
    
    * nits
    
    * revert wrong push of lasts commits
    sainoe committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f12a5c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. fix: make HandleConsumerDoubleVoting works with provider pubkeys (#…

    …1254)
    
    * fix double voting cli
    
    * fix bug double signing handler
    
    * godoc
    
    * nits
    
    * lint
    
    * nit
    sainoe committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    2501e83 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. fix: verify equivocation using validator pubkey in `SubmitConsumerDou…

    …bleVoting` msg (#1264)
    
    * verify dv evidence using malicious validator pubkey in infraction block header
    
    * nits
    
    * nits
    sainoe committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    eb6a079 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. refactor: update the E2E tests to work with Hermes relayer v1.6.0 (#1278

    )
    
    * save changes
    
    * fix hermes config
    
    * fist successful run
    
    * nit
    
    * nits
    
    * nits
    
    * doc and nits
    
    * lint
    sainoe committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    98af9c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. test: add E2E tests for double voting evidence handling (#1256)

    * fix double voting cli
    
    * add double-signing e2e test
    
    * refortmat e2e double voting test
    
    * godoc, revert unwanted changes
    
    * nit
    
    * verify dv evidence using malicious validator pubkey in infraction block header
    
    * save changes
    
    * fix hermes config
    
    * fist successful run
    
    * nit
    
    * nits
    
    * nits
    
    * doc and nits
    
    * lint
    
    * refactor
    
    * typo
    
    * change hermes docker image
    
    * nits
    
    * Update tests/e2e/steps.go
    
    Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
    
    * address PR comments
    
    * nits
    
    ---------
    
    Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
    sainoe and p-offtermatt committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c881a1a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. save

    sainoe committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a71f1fe View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. fix nits

    sainoe committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3be76ad View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/release/v2.1.x-lsm' into feat/…

    …ics-misbehaviour-handling
    sainoe committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    691d206 View commit details
    Browse the repository at this point in the history
  3. update changelog and fix nits

    sainoe committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    88e0717 View commit details
    Browse the repository at this point in the history