Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: add check for the height of evidence (backport #2007) #2027

Open
wants to merge 5 commits into
base: release/v5.1.x
Choose a base branch
from
Open

fix!: add check for the height of evidence (backport #2007) #2027

wants to merge 5 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 9, 2024

Please go to the Preview tab and select the appropriate sub-template:

  • Production code - for types fix, feat, and refactor.
  • Docs - for documentation changes.
  • Others - for changes that do not affect production code.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where the minimum height check for evidence in the consumer double-vote handler was missing, improving validation and error handling for double voting evidence.

  • Tests

    • Enhanced integration tests to better handle and validate scenarios involving double voting and misbehavior checks.

  • New Features

    • Added functionality to set and delete the minimum height for equivocation evidence related to a consumer chain.
This is an automatic backport of pull request #2007 done by [Mergify](https://mergify.com).

@sainoe @mergify
fix!: add check for the height of evidence (#2007)
16ea4be 
* init commit

* added check, setting, and deleting of the equivocation min height

* update changelog entry

* remove unwwanted changelog entry

---------

Co-authored-by: insumity <karolos@informal.systems>
(cherry picked from commit de9db96)
@mergify mergify bot requested a review from a team as a code owner July 9, 2024 06:33
@mergify mergify bot assigned sainoe Jul 9, 2024
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Jul 9, 2024
bermuell
bermuell reviewed Jul 10, 2024
View reviewed changes
CHANGELOG.md
@@ -40,6 +38,74 @@
([\#1698](https://github.com/cosmos/interchain-security/pull/1698))
- Revert `PutUnbondingOnHold` behavior to ICS@v1
([\#1819](https://github.com/cosmos/interchain-security/pull/1819))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken we just had changes specific to a major version in the changelog of a branch
saying v4.3.x branch had all changes since v4.3.x
Did we plan to change that or why is v5.1.x listing changes from v4.3.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bermuell bermuell bermuell left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@sainoe sainoe

Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bermuell @sainoe