Slash packet throttling #462
Conversation
Addressing this comment, this design does not violate a lot of the spec properties compared to alternatives like dropping slash packets. These are definitely valuable conversations, but I think they're best saved for the development of the slash packet throttling spec. I'll add a section in the doc about the max queue limit |
* reb * reb * Del unused Co-authored-by: Daniel <danwtisdall@gmail.com>
x/ccv/provider/types/keys.go
Outdated
| timeBzL := len(timeBz) | ||
| return AppendMany( | ||
| []byte{GlobalSlashEntryBytePrefix}, | ||
| sdk.Uint64ToBigEndian(uint64(timeBzL)), |
There was a problem hiding this comment.
This sorts by the number of bytes returned by sdk.FormatTimeBytes. Replace with uint64 as done in e440824
There was a problem hiding this comment.
Nice catch! When you have time could you sanity check 3b03354. It should be safe to parse the uint64 time back to a time.Time using recvTime = time.Unix(0, int64(timeBz)).UTC(), correct?
There was a problem hiding this comment.
LGTM. I would be more comfortable though once we have #607 fixed.
| vscMaturedData = []ccvtypes.VSCMaturedPacketData{} | ||
| ibcSeqNums = []uint64{} | ||
|
|
||
| iteratorLoop: |
There was a problem hiding this comment.
Change the switch to ifs to avoid using a label, becuase most people won't be familiar with labels
Description
Slash packets are now queued on the provider, and handled in a throttled manner.
Closes #404
Closes #595
I've kept #589 and #600 as separate PRs, but they are useful in validating the correctness of this feature. My suggestion is to merge them into main after this PR, once people have time to review them.
Protocol Description and Background
See md file in PR https://github.com/cosmos/interchain-security/blob/ba9965ec5fa8920008e3b1afc593277741e5c9e8/docs/throttle.md