fix IterateInitTimeoutTimestamp #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
requested review from
jtremback,
mpoke,
sainoe,
danwt and
shaspitz
as code owners
mpoke
approved these changes
Dec 3, 2022
sainoe
approved these changes
Dec 5, 2022
jtremback
reviewed
Dec 5, 2022
| @@ -332,11 +332,9 @@ func (k Keeper) EndBlockCCR(ctx sdk.Context) { | |||
| if currentTimeUint64 > ts { | |||
There was a problem hiding this comment.
Hey @MSalopek- can you add a comment on IterateInitTimeoutTimestamp (in different file), making it clear that it is not in order?
There was a problem hiding this comment.
Can you also open an issue on the repo (put it in the v1.1 milestone) to make IterateInitTimeoutTimestamp go in order? That would be a little better because it would avoid uneccesary iteration.
There was a problem hiding this comment.
Can do: #561. Can't tag it as 1.1 though, maybe I'm missing some access rights?
Are we expecting loads of chains to be removed due to timeouts? If we're iterating 5-20 items this does not seem worthwhile.
jtremback
approved these changes
Dec 5, 2022
MSalopek
force-pushed
the
masa/513-fix-consumer-rm-prop-iter
branch
from
0313d92
to
287450e
Compare
mpoke
reviewed
Dec 6, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
provider.EndBlockCCRremoves chains which timed out. However, when iterating through all chains, it stops as soon as it finds one chain that did not time out, falsely assuming that the chains are ordered by their time of arrival <=> expiration time.Linked issues
Closes: #513
Type of change
Please delete options that are not relevant.
How was the feature tested?
Other information
This bug was found during code audit.
Checklist:
Please delete options that are not relevant.
make test)IterateX(ctx sdk.Context, cb func(arg1, arg2) (stop bool)))