Change default max throttled packets params + small log fix #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
requested review from
jtremback,
mpoke,
sainoe and
danwt
as code owners
mpoke
approved these changes
Jan 5, 2023
sainoe
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following discussion in #594, this PR will change the default max throttled packets param from 1k -> 100k. I've also fixed a small typo in a throttle related panic message.
Linked issues
None closed
Type of change
Feature: Changes and/or adds code behavior, irrelevant to bug fixesRegression tests
Existing throttle tests, no new tests since we don't validate defaults.