Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47 done jq needs fixed #824

Closed
wants to merge 57 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 5, 2023

Description

Tests here are kind of a wierd flex.

go calls bash
bash calls jq

and there's replacey stuff in there, and .... it uses gaia v9

this PR would be a draft but CI won't run if it is a draft

Linked issues

Closes: #<issue>

Type of change

If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!

  • Feature: Changes and/or adds code behavior, irrelevant to bug fixes
  • Fix: Changes and/or adds code behavior, specifically to fix a bug
  • Refactor: Changes existing code style, naming, structure, etc.
  • Testing: Adds testing
  • Docs: Adds documentation

Regression tests

If Refactor, describe the new or existing tests that verify no behavior was changed or added where refactors were introduced.

New behavior tests

If Feature or Fix, describe the new or existing tests that verify the new behavior is correct and expected.

Versioning Implications

If the above box is checked, which version should be bumped?

  • MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)
  • MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)
  • PATCH: Non consensus breaking changes

Targeting

Please select one of the following:

  • This PR is only relevant to main
  • This PR is relevant to main, and should also be back-ported to ____ (ex: v1.0.0 and v1.1.0)
  • This PR is only relevant to ____ (ex: v1.0.0, v1.1.0, and v1.2.0)

@faddat
Copy link
Contributor Author

faddat commented Apr 5, 2023

taking this PR out of draft so that the automated tests run

@faddat faddat changed the title 47 done needs jq fixed 47 done jq needs fixed Apr 5, 2023
@faddat
Copy link
Contributor Author

faddat commented Apr 5, 2023

takin out of draft so that ci works

@faddat faddat marked this pull request as ready for review April 5, 2023 10:16
@faddat faddat mentioned this pull request Apr 5, 2023
4 tasks
@tac0turtle
Copy link
Member

coming here as this was mentioned in a issue in the sdk. @faddat please stop making general prs, they need to be focused on solving one or a limited amount of things at once. This is very hard to get reviewed and consume more time than you may expect. Please break this pr into smaller prs and make them focused on solving one issue at a time to track the changes better through git history.

@tac0turtle tac0turtle closed this Apr 7, 2023
@faddat
Copy link
Contributor Author

faddat commented Apr 9, 2023

@tac0turtle the ci system here doesn't work unless you have it actually open.

47 upgrades are very general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants