Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Run unit tests separately from e2e tests #867

Closed
wants to merge 14 commits into from
Closed

refactor: Run unit tests separately from e2e tests #867

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
389b40a
Create go-tests.yml
faddat Apr 20, 2023
633a124
Merge branch 'main' into patch-3
faddat Apr 21, 2023
72d220b
Merge branch 'main' into patch-3
faddat Apr 24, 2023
752cc5e
Merge branch 'main' into patch-3
faddat Apr 29, 2023
10e6220
run unit tests separately and use the verbose flag for e2e
faddat Apr 29, 2023
efa9aa1
Merge branch 'main' into patch-3
faddat May 2, 2023
c67a5ea
Update .github/workflows/go-tests.yml
faddat May 3, 2023
5638ba2
Update automated-tests.yml
faddat May 3, 2023
b5b4683
Rename automated-tests.yml to e2e-tests.yml
faddat May 3, 2023
78df7b3
Rename go-tests.yml to tests.yml
faddat May 3, 2023
fd2c99f
Merge branch 'main' into patch-3
faddat May 3, 2023
6a7bd29
Merge branch 'main' into patch-3
faddat May 5, 2023
03e0b03
Merge branch 'main' into patch-3
faddat May 6, 2023
86757f9
Merge branch 'main' into patch-3
faddat May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/automated-tests.yml
View file
Open in desktop
faddat marked this conversation as resolved.
Show resolved Hide resolved
@@ -1,4 +1,4 @@
name: Automated Tests
name: E2E Tests
on:
push:
branches:
Expand All @@ -9,7 +9,7 @@ on:
- main
- release/v*
jobs:
Automated_Tests:
E2E_Tests:
runs-on: ubuntu-latest
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
Expand All @@ -23,8 +23,6 @@ jobs:
with:
go-version: "1.19" # The Go version to download (if necessary) and use.

- name: Unit, integration and difference tests
run: go test ./...

- name: E2E tests
run: make test-e2e-short
run: go run ./tests/e2e/... --happy-path-only

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: go run ./tests/e2e/... --happy-path-only
run: make test-e2e-short

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh -- actually I'd meant to add --verbose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use make test-e2e-short. Developers can always run the tests locally with --verbose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we can't prove outcomes using CI, so that there's no debate, in the way that you recommend.

CI is a neutral and clearly defined build environment that can be used as proof of issues.

Copy link
Contributor Author

@faddat faddat May 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want proof, there is no reason whatsoever not to capture the logs.

15 changes: 15 additions & 0 deletions .github/workflows/go-tests.yml
View file
Open in desktop
faddat marked this conversation as resolved.
Show resolved Hide resolved
@@ -0,0 +1,15 @@
on: [push, pull_request]
name: Test
faddat marked this conversation as resolved.
Show resolved Hide resolved
jobs:
test:
strategy:
matrix:
go-version: [1.19.x, 1.20.x]
os: [ubuntu-latest, macos-latest, windows-latest]
faddat marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ matrix.os }}
steps:
- uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go-version }}
- uses: actions/checkout@v3
- run: go test ./...