Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move democracy consumer code to /x/ccv/consumer #883

Merged
merged 28 commits into from
Apr 26, 2023

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Apr 25, 2023

Description

Part of #801

Builds off #882, and simply moves democracy consumer code into x/ccv/consumer, along with adjusting a few references.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Base automatically changed from move-pb-files-to-types to feat/go-mod-split April 26, 2023 17:13
@shaspitz shaspitz changed the title Move democ to consumer refactor: move democracy consumer code to /x/ccv/consumer Apr 26, 2023
@shaspitz shaspitz marked this pull request as ready for review April 26, 2023 17:15
@shaspitz
Copy link
Contributor Author

See #882 (comment)

@shaspitz shaspitz merged commit 44a1f24 into feat/go-mod-split Apr 26, 2023
5 checks passed
@shaspitz shaspitz deleted the move-democ-to-consumer branch April 26, 2023 17:16
shaspitz added a commit that referenced this pull request Apr 26, 2023
* move utils to types

* regen pb files

* todo

* params -> consumerParams and providerParams

* mas proto changes

* consumer done

* mas

* rm prov genesis pb

* add

* mas

* mas

* progress is progress

* progresso chicken noodle soup

* un mas, calling it for today

* mas

* passes UTs

* woot

* diff tests

* fix router key bug

* fix tx commands

* Merge branch 'main' into add-go-mods

* lint fixes

* fix lint

* move the ish

* Update app.go

* Revert "Merge branch 'main' into add-go-mods"

This reverts commit 1e91d47.

* Revert "Revert "Merge branch 'main' into add-go-mods""

This reverts commit b1c4f8f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant