docs: Create adr-005-cryptographic-equivocation-verification.md #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtremback
changed the title
mpoke
changed the title
12 tasks
mpoke
reviewed
May 16, 2023
docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md
Outdated
Show resolved
Hide resolved
docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md
Outdated
Show resolved
Hide resolved
docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md
Outdated
Show resolved
Hide resolved
ancazamfir
reviewed
May 17, 2023
| Current limitations: | ||
|
|
||
| - This only handles light client attacks, not double signing. In the future, we will add the code to also verify double signing. | ||
| - Since a special endpoint must be used to submit the evidence, the evidence is not automatically submitted by Hermes. In the future, we may make Hermes submit the evidence, or use a hook provided by IBC to run the code automatically when evidence is submitted to the IBC client. In the current state, someone will need to submit the evidence manually in the 3 weeks after a light client attack has occured. |
There was a problem hiding this comment.
I don't understand this limitation. The whole point of adding that HandleConsumerMisbehaviour was for Hermes to submit the HandleConsumerMisbehaviour message automatically.
ancazamfir
reviewed
May 17, 2023
|
|
||
| - This only handles light client attacks, not double signing. In the future, we will add the code to also verify double signing. | ||
| - Since a special endpoint must be used to submit the evidence, the evidence is not automatically submitted by Hermes. In the future, we may make Hermes submit the evidence, or use a hook provided by IBC to run the code automatically when evidence is submitted to the IBC client. In the current state, someone will need to submit the evidence manually in the 3 weeks after a light client attack has occured. | ||
| - We currently can't derive an infraction height from the evidence, so it is only possible to tombstone validators, not actually slash them. |
There was a problem hiding this comment.
Could you clarify why this is?
ancazamfir
reviewed
May 17, 2023
|
|
||
| Current limitations: | ||
|
|
||
| - This only handles light client attacks, not double signing. In the future, we will add the code to also verify double signing. |
There was a problem hiding this comment.
Why don't we implement the double signing evidence handling from the start? Is there a tight deadline or technical reasons?
* save first gist * add first draft * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> --------- Co-authored-by: Marius Poke <marius.poke@posteo.de>
* add first draft * udpate refs * update * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Marius Poke <marius.poke@posteo.de> * add little changes * address comments * fix todos * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md * apply review suggestions * Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md --------- Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
mpoke
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ADR-005 which outlines the cryptographic equivocation verification feature
Closes #1124
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change