Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sdk47 post upgrade cleanup #970

Merged

Conversation

tbruyelle
Copy link
Contributor

@tbruyelle tbruyelle commented May 22, 2023

Description

At AIB we worked a little bit on the sdk47/ibc-v7 migration for this repository, but then you preferred to do it on your own. Anyway, since you just merged it #918, I took the time to compare our changes and yours and I found a small list of things that could be cleaned/improved/fixed :

  • de0fc66 remove remaining legacy LCD/REST queriers
  • c8f4713 simulation migration : ProposalContents can be deleted if the module has no proposal messages or proposal content to be tested by simulation.
  • f4b5ebb replace deprecated govv1.ParamKeyTable() by gov.ProvideKeyTable()
  • befa47d fix duplicate record of ante.DeductFeeDecorator. Probably the most important one, I don't think it's OK to call this ante two times for each block.

Let's discuss if you prefer to have this in separate PRs or if some of them are not correct/well-suited.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@tbruyelle tbruyelle requested a review from a team as a code owner May 22, 2023 10:58
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time and your contribution!

Approval.

@MSalopek MSalopek added scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run type: refactoring Code refactoring labels May 22, 2023
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MSalopek MSalopek merged commit 1bb8d39 into cosmos:feat/upgrade-ics-sdk47-ibc7 May 22, 2023
4 checks passed
@tbruyelle tbruyelle deleted the chore/sdk47-cleanup branch May 22, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: cosmos-sdk Integration with Cosmos SDK type: refactoring Code refactoring type: tech-debt Slows down development in the long run
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants