Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

GolangCI-Lint Error #75

Closed
jgr-great opened this issue Mar 18, 2020 · 2 comments
Closed

GolangCI-Lint Error #75

jgr-great opened this issue Mar 18, 2020 · 2 comments

Comments

@jgr-great
Copy link

➜  relayer git:(master) ✗ make
running GolangCI-Lint...
cmd/flags.go:137:17: Error return value of `viper.BindPFlag` is not checked (errcheck)
	viper.BindPFlag(flagURL, cmd.Flags().Lookup(flagURL))
	               ^
cmd/raw.go:59:11: nilness: impossible condition: nil != nil (govet)
			if err != nil {
			       ^
make: *** [ci-lint] Error 1
@jhernandezb jhernandezb mentioned this issue Mar 18, 2020
@JakeHartnell
Copy link

I also had this issue. The open PR fixed it for me: cosmos/relayer#77

Thanks @jhernandezb!

@jackzampolin
Copy link
Member

Thank you @jhernandezb, I've got all the lint issues fixed over at https://github.com/iqlusioninc/relayer. If you continue to see issues, please open them over there.

bluele pushed a commit to datachainlab/cosmos-relayer-archive that referenced this issue Apr 21, 2020
Add simplystaking chain to testnet
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants