Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockResults rpc has changed in comet v0.38 update #1273

Closed
colin-axner opened this issue Aug 30, 2023 · 1 comment
Closed

BlockResults rpc has changed in comet v0.38 update #1273

colin-axner opened this issue Aug 30, 2023 · 1 comment

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Aug 30, 2023

v0.34.X Block Results RPC:

// ABCI results from a block
type ResultBlockResults struct {
	Height                int64                     `json:"height"`
	TxsResults            []*abci.ResponseDeliverTx `json:"txs_results"`
	BeginBlockEvents      []abci.Event              `json:"begin_block_events"`
	EndBlockEvents        []abci.Event              `json:"end_block_events"`
	ValidatorUpdates      []abci.ValidatorUpdate    `json:"validator_updates"`
	ConsensusParamUpdates *abci.ConsensusParams     `json:"consensus_param_updates"`
}

v0.38.X Block Results RPC:

// ABCI results from a block
type ResultBlockResults struct {
	Height                int64                     `json:"height"`
	TxsResults            []*abci.ExecTxResult      `json:"txs_results"`
	FinalizeBlockEvents   []abci.Event              `json:"finalize_block_events"`
	ValidatorUpdates      []abci.ValidatorUpdate    `json:"validator_updates"`
	ConsensusParamUpdates *cmtproto.ConsensusParams `json:"consensus_param_updates"`
	AppHash               []byte                    `json:"app_hash"`
}

The relayer currently looks for begin and end blocks here after performing this rpc query

This results in no begin/end block results for chains on SDK v0.50

Begin/End block event parsing is needed for interchain accounts integration with gov/groups SDK modules

@jtieri
Copy link
Member

jtieri commented Dec 7, 2023

This was addressed in #1312 by maintaining a fork of cometbft before v0.38.0 and importing that fork as well. It seems like cometbft will soon have a stable v1.0.0 release, at that point we should be able to drop the fork entirely as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants