Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for auto update client #1025

Merged
merged 5 commits into from
Nov 3, 2022
Merged

Add docs for auto update client #1025

merged 5 commits into from
Nov 3, 2022

Conversation

boojamya
Copy link
Contributor

@boojamya boojamya commented Oct 26, 2022 •
edited
Loading

This PR

  • Adds documentation for the auto-update client feature and the --time-threshold flag.
  • In the troubleshooting section, it removes outdated "healthy relayer logs"
  • In the troubleshooting section, it adds note about rly chains list cmd
  • Groups prometheus metrics and auto-update client usage into "Advanced Usage" doc
  • Adds/removes bullet points in the features.md

Closes: #1024

@boojamya boojamya marked this pull request as ready for review October 26, 2022 00:23
jtieri
jtieri approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Dan! 👍
Couple comments but nothing that should block merging this

docs/advanced_usage.md Outdated Show resolved Hide resolved
docs/advanced_usage.md Outdated Show resolved Hide resolved
agouin
agouin reviewed Nov 1, 2022
View reviewed changes
docs/advanced_usage.md Outdated Show resolved Hide resolved
docs/advanced_usage.md Outdated Show resolved Hide resolved
@boojamya boojamya merged commit 3f8c0ca into main Nov 3, 2022
@boojamya boojamya deleted the readmeupdate-10-22 branch November 3, 2022 17:57
agouin pushed a commit that referenced this pull request Nov 9, 2022
@boojamya @agouin
Add docs for auto update client (#1025)
6108b92 
* update docs

* nits

* handle feedback
agouin pushed a commit that referenced this pull request Nov 15, 2022
@boojamya @agouin
Add docs for auto update client (#1025)
af8e56a 
* update docs

* nits

* handle feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agouin agouin agouin left review comments

@jtieri jtieri jtieri approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation around the auto update client feature
3 participants
@boojamya @agouin @jtieri